Register lamella evaluation image - #883
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
+ Coverage 55.10% 55.16% +0.05%
==========================================
Files 102 102
Lines 11367 11393 +26
Branches 1508 1512 +4
==========================================
+ Hits 6264 6285 +21
- Misses 4767 4771 +4
- Partials 336 337 +1 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
September 10, 2026 18:05
stephen-riggs
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension of the FIB workflow file registration logic. This PR ensures that an
ImagingSitetable entry is created for every incoming lamella evaluation image. Logic has been put in such that, in the event the images are registered out of order, the image with the newer timestamp in the file stem will be kept.Subsequent PRs will involve ensuring the creation of the
DataCollectionGroup,Atlas, andGridSquaretables, and linking them to one another correctly based solely on the incoming lamella evaluation image.