Skip to content

Register lamella evaluation image - #883

Merged
tieneupin merged 12 commits into
mainfrom
register-lamella-evaluation-image
Sep 11, 2026
Merged

Register lamella evaluation image#883
tieneupin merged 12 commits into
mainfrom
register-lamella-evaluation-image

Conversation

@tieneupin

@tieneupin tieneupin commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Extension of the FIB workflow file registration logic. This PR ensures that an ImagingSite table entry is created for every incoming lamella evaluation image. Logic has been put in such that, in the event the images are registered out of order, the image with the newer timestamp in the file stem will be kept.

Subsequent PRs will involve ensuring the creation of the DataCollectionGroup, Atlas, and GridSquare tables, and linking them to one another correctly based solely on the incoming lamella evaluation image.

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.16%. Comparing base (8b02ba1) to head (3bdc2b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
+ Coverage   55.10%   55.16%   +0.05%     
==========================================
  Files         102      102              
  Lines       11367    11393      +26     
  Branches     1508     1512       +4     
==========================================
+ Hits         6264     6285      +21     
- Misses       4767     4771       +4     
- Partials      336      337       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin
tieneupin marked this pull request as ready for review September 10, 2026 18:05
@tieneupin tieneupin self-assigned this Sep 10, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component fib Part of the FIB pipeline extension labels Sep 10, 2026

@stephen-riggs stephen-riggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Comment thread src/murfey/workflows/fib/register_lamella_evaluation_image.py Outdated
Comment thread src/murfey/workflows/fib/register_lamella_evaluation_image.py
@tieneupin
tieneupin merged commit 916f17b into main Sep 11, 2026
14 checks passed
@tieneupin
tieneupin deleted the register-lamella-evaluation-image branch September 11, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants