Standardise contexts#844
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 53.56% 54.41% +0.85%
==========================================
Files 103 103
Lines 11085 11042 -43
Branches 1477 1466 -11
==========================================
+ Hits 5938 6009 +71
+ Misses 4829 4713 -116
- Partials 318 320 +2 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
July 22, 2026 05:14
tieneupin
added
enhancement
tieneupin
force-pushed
the
standardise-contexts
branch
from
July 22, 2026 06:23
abfae0b to
6fa3a04
Compare
…sferred_to' functions
…nsferred_to' functions
d-j-hatton
approved these changes
Jul 24, 2026
tieneupin
force-pushed
the
standardise-contexts
branch
from
July 24, 2026 14:43
6fa3a04 to
d9bf915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FIBContextandCLEMContextclasses were written with their own versions of functions that we have now established to be shared across the classes. This PR standardisesFIBContextandCLEMContextby replacing the_get_sourceand_file_transferred_tofunctions defined within the modules with the shared version of said functions. Also adds tests for theCLEMContext.Actual code diff is +21/-111. The rest of the diff is due to the updating and adding of tests.