Fix testing module dependency on httpx - #198
Merged
Merged
Conversation
Relm-Arrowny
approved these changes
Jul 28, 2026
Relm-Arrowny
left a comment
Collaborator
There was a problem hiding this comment.
LFTM, no reason for it to be inside the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to update dodal to latest release of daq-config-server, have ran into a dependency issue when trying to import from testing module
This is because we have a
make_test_responsefunction which is in testing module which has a dependency onhttpxand isn't a hard dependency for daq-config-server. Rather than adding the dependency, I have moved the function to tests only as that is where it is ever used. I have also checked plan repositories and it isn't used there either so safe to remove from testing and define it only where it is used.