Skip to content

LIMS-2282: Use the same callback URL for both incoming and outgoing dewars - #1087

Open
ndg63276 wants to merge 1 commit into
masterfrom
improvement/LIMS-2282/use-same-callback-url-for-incoming-and-outgoing
Open

LIMS-2282: Use the same callback URL for both incoming and outgoing dewars#1087
ndg63276 wants to merge 1 commit into
masterfrom
improvement/LIMS-2282/use-same-callback-url-for-incoming-and-outgoing

Conversation

@ndg63276

Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2282

Summary:

We currently have 2 separate callback URLs for the shipping service to use for incoming and outgoing shipments. We should combine them into one endpoint, and then figure out what is happening based on the journey_type sent in by the shipping service. This is needed so we can use the same shipment request for incoming and outgoing, which is needed for EU shipments.

Changes:

  • Remove confirmdispatch and confirmpickup endpoints, add a single confirm endpoint, adjust the authentication to match
  • Always use the same confirm endpoint, with a dewar id and token (for incoming, any dewar id in the shipment is fine)
  • Create a new function to split requests depending on journey_type
  • Move some of the checks for args into the new function

To test:

  • Go to an mx proposal, eg mx23694, go to /shipments/add and create a shipment
    • Say it is for a UDC visit
    • Use a UK based Lab Contact
    • use the facility DHL account
  • Once created, click "Create DHL Air Waybill" in the top right
  • Tick the dewar and click "Proceed"
  • Fill in the address in the shipping service, and accept the Ts & Cs, ask for a pick up, and then click "Submit"
  • Once back in Synchweb, check the dewar now has status "pickup booked" and there is an incoming tracking number
  • Now click "Dispatch" on the right hand side, and go through the shipping service to book the return (outgoing) shipment
  • Once back in Synchweb, check the dewar status is "dispatch-booked" and there is an outgoing tracking number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants