Skip to content

Scheduler: fix appointment resizing when grouping by date - #34653

Open
aleksei-semikozov wants to merge 1 commit into
DevExpress:mainfrom
aleksei-semikozov:scheduler-groupbydate-resize-parts
Open

Scheduler: fix appointment resizing when grouping by date#34653
aleksei-semikozov wants to merge 1 commit into
DevExpress:mainfrom
aleksei-semikozov:scheduler-groupbydate-resize-parts

Conversation

@aleksei-semikozov

Copy link
Copy Markdown
Contributor

No description provided.

@aleksei-semikozov aleksei-semikozov self-assigned this Aug 4, 2026
@aleksei-semikozov
aleksei-semikozov marked this pull request as ready for review August 4, 2026 23:51
@aleksei-semikozov
aleksei-semikozov requested a review from a team as a code owner August 4, 2026 23:51
Copilot AI review requested due to automatic review settings August 4, 2026 23:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Scheduler appointment resizing issues in group-by-date mode by computing the resized date range using cell column indexes (instead of relying on cellData.index, which can represent a date index when grouping-by-date repeats columns per group). It also restores correct “reduced-part” behavior (needed for correct resize handles) while explicitly suppressing the reduced icon in group-by-date views.

Changes:

  • Refactors horizontal date-range calculation during resizing to correctly find the “right border” cell via column indexes (with RTL support and row-bound clamping).
  • Introduces hideReducedIcon for appointment rendering so reduced-part handle logic remains intact while hiding reduced UI in group-by-date workspaces.
  • Adds Jest coverage for both the low-level date-range computation and an integration scenario verifying resize handles/reduced UI in group-by-date.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/scheduler/appointments/resizing/m_core.ts Fixes horizontal resize date-range computation by using cell column indexes for left/right border lookup (including RTL).
packages/devextreme/js/__internal/scheduler/appointments/resizing/m_core.test.ts Adds unit tests covering group-by-date behavior, RTL mirroring, and row-bound clamping for horizontal resizing.
packages/devextreme/js/__internal/scheduler/appointments/m_appointment_collection.ts Always passes reduced (to preserve reduced-part handle behavior) and introduces hideReducedIcon for group-by-date.
packages/devextreme/js/__internal/scheduler/appointments/appointment/m_types.ts Extends appointment props with hideReducedIcon.
packages/devextreme/js/__internal/scheduler/appointments/appointment/m_appointment.ts Adds hideReducedIcon option handling and suppresses reduced rendering when enabled.
packages/devextreme/js/__internal/scheduler/tests/appointments_resizing.test.ts Adds integration tests ensuring only edge parts have resize handles and reduced UI is not rendered in group-by-date scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants