Scheduler: fix appointment resizing when grouping by date - #34653
Open
aleksei-semikozov wants to merge 1 commit into
Open
Scheduler: fix appointment resizing when grouping by date#34653aleksei-semikozov wants to merge 1 commit into
aleksei-semikozov wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Scheduler appointment resizing issues in group-by-date mode by computing the resized date range using cell column indexes (instead of relying on cellData.index, which can represent a date index when grouping-by-date repeats columns per group). It also restores correct “reduced-part” behavior (needed for correct resize handles) while explicitly suppressing the reduced icon in group-by-date views.
Changes:
- Refactors horizontal date-range calculation during resizing to correctly find the “right border” cell via column indexes (with RTL support and row-bound clamping).
- Introduces
hideReducedIconfor appointment rendering so reduced-part handle logic remains intact while hiding reduced UI in group-by-date workspaces. - Adds Jest coverage for both the low-level date-range computation and an integration scenario verifying resize handles/reduced UI in group-by-date.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/appointments/resizing/m_core.ts | Fixes horizontal resize date-range computation by using cell column indexes for left/right border lookup (including RTL). |
| packages/devextreme/js/__internal/scheduler/appointments/resizing/m_core.test.ts | Adds unit tests covering group-by-date behavior, RTL mirroring, and row-bound clamping for horizontal resizing. |
| packages/devextreme/js/__internal/scheduler/appointments/m_appointment_collection.ts | Always passes reduced (to preserve reduced-part handle behavior) and introduces hideReducedIcon for group-by-date. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/m_types.ts | Extends appointment props with hideReducedIcon. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/m_appointment.ts | Adds hideReducedIcon option handling and suppresses reduced rendering when enabled. |
| packages/devextreme/js/__internal/scheduler/tests/appointments_resizing.test.ts | Adds integration tests ensuring only edge parts have resize handles and reduced UI is not rendered in group-by-date scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.