FileManager - Update currentPath in v26.2 - #34641
Open
AlisherAmonulloev wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the FileManager “Overview” demos to start in the Places directory instead of Widescreen, aligning the initial currentPath shown to users across framework examples.
Changes:
- Updated the initial
currentPathin the Vue demo. - Updated the initial
currentPathstate/value in the React (TS) and ReactJs demos. - Updated the initial
currentPathoption/value in the Angular and jQuery demos.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/FileManager/Overview/Vue/App.vue | Changes FileManager current-path initial value to Places. |
| apps/demos/Demos/FileManager/Overview/ReactJs/App.js | Changes initial currentPath React state to Places. |
| apps/demos/Demos/FileManager/Overview/React/App.tsx | Changes initial currentPath React state to Places. |
| apps/demos/Demos/FileManager/Overview/jQuery/index.js | Changes FileManager currentPath option to Places. |
| apps/demos/Demos/FileManager/Overview/Angular/app/app.component.html | Changes FileManager currentPath attribute to Places. |
IlyaKhD
force-pushed
the
chore/filemanager-overview-currentpath
branch
from
August 6, 2026 15:17
ee1188c to
a8fa5a1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (5)
apps/demos/Demos/FileManager/Overview/Vue/App.vue:6
current-pathis set to "Places", but the TestCafe demo request mock forfile-manager-file-system-images(apps/demos/testing/apiMocks/fixtures/fileManagerImages.json) exposes a root folder named "Widescreen" and does not include "Places". With mocks enabled, the demo may start in a non-existent directory (empty/fallback UI), breaking visual tests. Update the mock fixture to include/rename the folder to "Places" (and any related keys/URLs), or keep the demo’s initial path consistent with the mocked dataset.
current-path="Places"
apps/demos/Demos/FileManager/Overview/ReactJs/App.js:10
- Initial
currentPathis now "Places", but the demo API mock dataset used by TestCafe visual tests (apps/demos/testing/apiMocks/fixtures/fileManagerImages.json forfile-manager-file-system-images) contains "Widescreen" and no "Places" folder. This can cause the mocked demo to open an empty/non-existent directory and change screenshots. Update the fixture to match the new folder name, or keep the initialcurrentPathaligned with the mocked data.
const [currentPath, setCurrentPath] = useState('Places');
apps/demos/Demos/FileManager/Overview/React/App.tsx:12
currentPathdefault changed to "Places", but the TestCafe request mock for the remote file system images endpoint uses apps/demos/testing/apiMocks/fixtures/fileManagerImages.json, which defines a root folder "Widescreen" and no "Places". With mocks enabled, this can lead to an empty/fallback initial directory and break visual test baselines. Update the fixture (folder name + keys/URLs) to include "Places", or keep the default path consistent with the fixture.
const [currentPath, setCurrentPath] = useState('Places');
apps/demos/Demos/FileManager/Overview/jQuery/index.js:9
currentPathis now "Places", but the TestCafe demo service mock forfile-manager-file-system-imagesis backed by apps/demos/testing/apiMocks/fixtures/fileManagerImages.json, which contains "Widescreen" and no "Places" folder. Under mocks this may open a non-existent directory (empty/fallback), changing visual test output. Update the fixture to match the new folder name (and its keys/URLs), or keepcurrentPathconsistent with the mocked dataset.
currentPath: 'Places',
apps/demos/Demos/FileManager/Overview/Angular/app/app.component.html:4
currentPathis set to "Places", but the TestCafe request mock for the FileManager images endpoint uses apps/demos/testing/apiMocks/fixtures/fileManagerImages.json, whose root folders include "Widescreen" and do not include "Places". With mocks enabled, the demo may start in a missing directory and alter visual test screenshots. Update the fixture to include/rename to "Places" (plus related keys/URLs), or keep the initialcurrentPathaligned with the mocked dataset.
currentPath="Places"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.