Skip to content

FileManager - Update currentPath in v26.2 - #34641

Open
AlisherAmonulloev wants to merge 1 commit into
mainfrom
chore/filemanager-overview-currentpath
Open

FileManager - Update currentPath in v26.2#34641
AlisherAmonulloev wants to merge 1 commit into
mainfrom
chore/filemanager-overview-currentpath

Conversation

@AlisherAmonulloev

Copy link
Copy Markdown
Contributor

No description provided.

@AlisherAmonulloev AlisherAmonulloev self-assigned this Aug 4, 2026
@AlisherAmonulloev
AlisherAmonulloev marked this pull request as ready for review August 5, 2026 06:40
Copilot AI review requested due to automatic review settings August 5, 2026 06:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the FileManager “Overview” demos to start in the Places directory instead of Widescreen, aligning the initial currentPath shown to users across framework examples.

Changes:

  • Updated the initial currentPath in the Vue demo.
  • Updated the initial currentPath state/value in the React (TS) and ReactJs demos.
  • Updated the initial currentPath option/value in the Angular and jQuery demos.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/demos/Demos/FileManager/Overview/Vue/App.vue Changes FileManager current-path initial value to Places.
apps/demos/Demos/FileManager/Overview/ReactJs/App.js Changes initial currentPath React state to Places.
apps/demos/Demos/FileManager/Overview/React/App.tsx Changes initial currentPath React state to Places.
apps/demos/Demos/FileManager/Overview/jQuery/index.js Changes FileManager currentPath option to Places.
apps/demos/Demos/FileManager/Overview/Angular/app/app.component.html Changes FileManager currentPath attribute to Places.

Copilot AI review requested due to automatic review settings August 6, 2026 15:17
@IlyaKhD
IlyaKhD force-pushed the chore/filemanager-overview-currentpath branch from ee1188c to a8fa5a1 Compare August 6, 2026 15:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (5)

apps/demos/Demos/FileManager/Overview/Vue/App.vue:6

  • current-path is set to "Places", but the TestCafe demo request mock for file-manager-file-system-images (apps/demos/testing/apiMocks/fixtures/fileManagerImages.json) exposes a root folder named "Widescreen" and does not include "Places". With mocks enabled, the demo may start in a non-existent directory (empty/fallback UI), breaking visual tests. Update the mock fixture to include/rename the folder to "Places" (and any related keys/URLs), or keep the demo’s initial path consistent with the mocked dataset.
      current-path="Places"

apps/demos/Demos/FileManager/Overview/ReactJs/App.js:10

  • Initial currentPath is now "Places", but the demo API mock dataset used by TestCafe visual tests (apps/demos/testing/apiMocks/fixtures/fileManagerImages.json for file-manager-file-system-images) contains "Widescreen" and no "Places" folder. This can cause the mocked demo to open an empty/non-existent directory and change screenshots. Update the fixture to match the new folder name, or keep the initial currentPath aligned with the mocked data.
  const [currentPath, setCurrentPath] = useState('Places');

apps/demos/Demos/FileManager/Overview/React/App.tsx:12

  • currentPath default changed to "Places", but the TestCafe request mock for the remote file system images endpoint uses apps/demos/testing/apiMocks/fixtures/fileManagerImages.json, which defines a root folder "Widescreen" and no "Places". With mocks enabled, this can lead to an empty/fallback initial directory and break visual test baselines. Update the fixture (folder name + keys/URLs) to include "Places", or keep the default path consistent with the fixture.
  const [currentPath, setCurrentPath] = useState('Places');

apps/demos/Demos/FileManager/Overview/jQuery/index.js:9

  • currentPath is now "Places", but the TestCafe demo service mock for file-manager-file-system-images is backed by apps/demos/testing/apiMocks/fixtures/fileManagerImages.json, which contains "Widescreen" and no "Places" folder. Under mocks this may open a non-existent directory (empty/fallback), changing visual test output. Update the fixture to match the new folder name (and its keys/URLs), or keep currentPath consistent with the mocked dataset.
    currentPath: 'Places',

apps/demos/Demos/FileManager/Overview/Angular/app/app.component.html:4

  • currentPath is set to "Places", but the TestCafe request mock for the FileManager images endpoint uses apps/demos/testing/apiMocks/fixtures/fileManagerImages.json, whose root folders include "Widescreen" and do not include "Places". With mocks enabled, the demo may start in a missing directory and alter visual test screenshots. Update the fixture to include/rename to "Places" (plus related keys/URLs), or keep the initial currentPath aligned with the mocked dataset.
  currentPath="Places"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants