Accordion: allow validation messages to overflow in opened items (T1327641)#33512
Merged
pharret31 merged 5 commits intoDevExpress:26_1from May 7, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DevExtreme Accordion’s runtime styling so validation messages (and other content) can visually overflow outside an opened item after the expand animation completes, and adds QUnit coverage to lock in the expected behavior.
Changes:
- Reset inline
overflowon items (and their bodies) when a height update/animation starts, so closing/opening transitions don’t keepoverflow: visible. - Apply
overflow: visibleto opened items (and their bodies) once the open animation finishes. - Add QUnit tests covering opened/closed behavior, multiple mode, close-start reset, post-animation application, and reopen restoration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/accordion.tests.js | Adds a new test module validating overflow behavior across open/close scenarios and animation timing. |
| packages/devextreme/js/__internal/ui/accordion.ts | Resets overflow at animation start and sets overflow: visible for opened items after animation completion. |
pharret31
force-pushed
the
26_1_4086-validation-message-truncation-in-accordion
branch
from
aaa640a to
db7c6a3
Compare
dmlvr
approved these changes
May 7, 2026
This was referenced May 7, 2026
marker-dao
pushed a commit
to marker-dao/DevExtreme
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.