TextEditorMask: Refactor and improve typing#32572
Open
marker-dao wants to merge 38 commits intoDevExpress:26_1from
Open
TextEditorMask: Refactor and improve typing#32572marker-dao wants to merge 38 commits intoDevExpress:26_1from
marker-dao wants to merge 38 commits intoDevExpress:26_1from
Conversation
marker-dao
force-pushed
the
26_1_texteditor_masks
branch
from
623f3c1 to
44757c5
Compare
r-farkhutdinov
previously approved these changes
Feb 13, 2026
marker-dao
force-pushed
the
26_1_texteditor_masks
branch
from
1d43728 to
cd18b6f
Compare
marker-dao
force-pushed
the
26_1_texteditor_masks
branch
from
b3b27a9 to
ceeb7cd
Compare
added 15 commits
February 20, 2026 18:40
marker-dao
force-pushed
the
26_1_texteditor_masks
branch
from
185e44b to
60aa9a8
Compare
Comment on lines
+561
to
+565
| const currentCaret = this._caret()?.start; | ||
|
|
||
| this._adjustCaret(); | ||
| return !currentCaret || currentCaret !== this._caret().start; | ||
|
|
||
| return !currentCaret || currentCaret !== this._caret()?.start; |
There was a problem hiding this comment.
_tryMoveCaretBackward uses a falsy check (!currentCaret) to detect whether the caret position changed. This makes the method return true when the caret is at position 0 (because 0 is falsy), even if the caret did not move. Consider comparing against undefined explicitly (or using isDefined) and returning currentCaret !== this._caret()?.start only when a previous caret value is actually available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.