feat(api): add cart promo-code endpoint#34
Open
mgouia wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
POST /api/cart/promo-codeendpoint that validates cart/promo inputs and applies percentage-based promo discounts to cart totals. The change also extends cart discount logic with reusable percentage helpers and adds tests that cover discount resolution and endpoint responses.Changes
app/api/cart/promo-code/route.tswith boundary validation, authN/authZ checks, promo applicability checks, and totals response.lib/cart.tsto centralize percentage promo resolution (resolvePromoCodePercent) and bounded discount calculation (applyPercentageDiscount), then reused this logic inapplyDiscount.tests/cart.test.tswith promo percentage and clamping coverage.tests/promo-code-route.test.tsto cover unauthorized, forbidden, invalid/inapplicable promo code, and successful discount application cases..eslintrc.json,next-env.d.ts) and Next TypeScript plugin/include defaults intsconfig.jsonsonext lintruns non-interactively.Testing
npm run lint: PASSnpm test: PASSOut of scope (noted for follow-up)
Check failures (if any)
None -- all checks green
Guideline compliance