feat(skills): add build-and-pr and framework-modernizer skills#33
Open
mgouia wants to merge 2 commits into
Open
feat(skills): add build-and-pr and framework-modernizer skills#33mgouia wants to merge 2 commits into
mgouia wants to merge 2 commits into
Conversation
- Add .github/skills/build-and-pr skill: given a feature brief or review findings, implements the change on a new branch, loads team guidelines (security, architecture, docs), runs npm run lint and npm test (fixing failures before continuing), then opens or updates a PR. Out-of-scope items noted in PR description rather than coded. - Add framework-modernizer skill with full evals suite, breaking- changes reference, classifier rubric, and phased plan template. - Add my-skill placeholder stub as install harness target. - Mirror both skills into .apm/skills/ for APM module resolution. - Update apm.lock.yaml to reflect new skill registrations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The team needed two new Copilot skills to close gaps in the developer workflow:
build-and-pr-- there was no automated path from a feature brief or review findings to a ready-to-merge PR. Developers had to manually branch, implement, validate, and open PRs while keeping the team's security/architecture/docs standards in mind.framework-modernizer-- Express 4 deprecation warnings surfaced in the codebase with no structured migration playbook or automated audit path.What changed
build-and-prskill (.github/skills/build-and-pr/)Given a work item (feature brief or list of review findings), the skill:
architect.agent.md,security.agent.md, and the auto-injected instruction files) before writing any codenpm run lintandnpm test, fixing failures before continuing (up to 3 cycles; escalates to the user on the third failure)The skill was designed following the genesis architecture discipline: A2 PIPELINE + A9 SUPERVISED EXECUTION (weak form) with S7 deterministic tool bridges for all git/gh/npm interactions.
framework-modernizerskill (.agents/skills/+.apm/skills/)Audits an Express 4 codebase for breaking changes, classifies findings as SAFE/AUTOFIX/MANUAL, applies safe autofixes, and emits a phased migration plan. Includes:
evals/evals.json, trigger evals, fixtures)references/express-4-to-5-breaking-changes.md)Other
my-skillplaceholder stub added as an APM install harness target.apm/skills/for APM module resolutionapm.lock.yamlupdated to register the new skillsNotes for reviewers
build-and-prskill uses weak-form A9 supervision (the agent holds write capability). Strong-form would require agh-awSafeOutputs surface, which isn't wired here. This is intentional and noted in the genesis handoff packet.zava-storefront/package-lock.jsonfile added in an earlier commit is a generated artifact from the nested directory and can be ignored..agents/tree and.apm/tree are mirrors; if the install path changes, only one needs updating.