Skip to content

feat(trace_exporter): enable telemetry in stats exporter#2160

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter
Jul 3, 2026
Merged

feat(trace_exporter): enable telemetry in stats exporter#2160
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter

Conversation

@VianneyRuhlmann

@VianneyRuhlmann VianneyRuhlmann commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Enable sending telemetry and health metrics from the stats exporter.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

VianneyRuhlmann commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 72.34%
Overall Coverage: 74.39% (-0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 06d7629 | Docs | Datadog PR Page | Give us feedback!

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 3 3 No change (0%)
Total 3 3 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
libdd-data-pipeline/src/telemetry/mod.rs 1 1 No change (0%)
libdd-data-pipeline/src/trace_exporter/mod.rs 2 2 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 22 22 No change (0%)
datadog-live-debugger 4 4 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-sidecar 45 45 No change (0%)
libdd-common 13 13 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 6 6 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-remote-config 3 3 No change (0%)
libdd-telemetry 20 20 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 3 3 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 11 11 No change (0%)
Total 182 182 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review June 24, 2026 17:00
@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner June 24, 2026 17:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e641e9a507

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libdd-data-pipeline/src/trace_exporter/mod.rs Outdated
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from e641e9a to adc72e5 Compare June 24, 2026 17:17
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_stats_send_telemetry_for_cardinality_limits branch 2 times, most recently from 98f8c1d to fffe30d Compare June 24, 2026 17:41
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from adc72e5 to dc75ab9 Compare June 24, 2026 17:41
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_stats_send_telemetry_for_cardinality_limits branch from fffe30d to e5c0f96 Compare June 24, 2026 17:50
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from dc75ab9 to 372e45e Compare June 24, 2026 17:50
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_stats_send_telemetry_for_cardinality_limits branch from e5c0f96 to d97928e Compare June 24, 2026 17:59
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from 372e45e to 4dd43bf Compare June 24, 2026 17:59
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_stats_send_telemetry_for_cardinality_limits branch from d97928e to c84447e Compare June 24, 2026 18:15
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from 4dd43bf to 7059117 Compare June 24, 2026 18:15

@ajgajg1134 ajgajg1134 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I'm definitely not an expert in this area (yet? 😛)

@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.88 MB 7.88 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 85.64 MB 85.67 MB +.02% (+24.65 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.60 MB 10.60 MB +0% (+480 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 96.81 MB 96.83 MB +.02% (+25.50 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.41 MB 25.42 MB +.02% (+5.50 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.44 KB +.45% (+410 B) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.51 MB 184.54 MB +.01% (+32.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 945.48 MB 946.63 MB +.12% (+1.15 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.29 MB 8.30 MB +.02% (+2.50 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.44 KB +.45% (+410 B) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.52 MB 24.53 MB +.03% (+8.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.85 MB 48.86 MB +.03% (+15.86 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.02 MB 22.02 MB +.01% (+4.50 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.82 KB +.45% (+414 B) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.52 MB 188.56 MB +.02% (+40.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 932.67 MB 933.84 MB +.12% (+1.16 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.41 MB 6.41 MB +.02% (+1.50 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.82 KB +.45% (+414 B) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.32 MB 26.33 MB +.02% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 46.48 MB 46.49 MB +.03% (+14.47 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 76.38 MB 76.40 MB +.02% (+22.79 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.76 MB 8.76 MB +.04% (+4.00 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.86 MB 91.88 MB +.02% (+23.08 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.66 MB 10.66 MB +.03% (+4.35 KB) 🔍

@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_stats_send_telemetry_for_cardinality_limits branch from c84447e to 98080a6 Compare June 29, 2026 11:58
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch 2 times, most recently from 8a116a5 to b86aa6e Compare June 29, 2026 12:44
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_stats_send_telemetry_for_cardinality_limits branch 2 times, most recently from 5294954 to b1f49f4 Compare June 29, 2026 14:20
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from b86aa6e to 8fcfab9 Compare June 29, 2026 14:20
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from 8fcfab9 to 94ad5e8 Compare June 29, 2026 15:35
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_stats_send_telemetry_for_cardinality_limits branch from a9738ee to 883025f Compare June 30, 2026 14:56
@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from dae98bf to 3a03e6a Compare June 30, 2026 14:56
Base automatically changed from 06-24-feat_stats_send_telemetry_for_cardinality_limits to main June 30, 2026 18:04
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot requested review from a team as code owners June 30, 2026 18:04
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot requested review from mabdinur and removed request for a team June 30, 2026 18:04
@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-30 18:04:40 UTC ℹ️ Start processing command devflow:merge


2026-06-30 18:04:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-06-30 22:08:11 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@VianneyRuhlmann VianneyRuhlmann force-pushed the 06-24-feat_trace_exporter_enable_telemetry_in_stats_exporter branch from 8745b80 to 06d7629 Compare July 2, 2026 13:39
@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 3, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-03 12:18:13 UTC ℹ️ Start processing command devflow:merge


2026-07-03 12:18:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-07-03 13:04:01 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants