feat: Adopt TraceExporter's Telemetry stuff by Aaalibaba42 · Pull Request #183 · DataDog/libdatadog-nodejs

Aaalibaba42 · 2026-07-20T16:48:13Z

No description provided.

github-actions · 2026-07-20T16:56:36Z

Overall package size

Self size: 30.44 MB
Deduped: 30.44 MB
No deduping: 30.44 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------|

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa886f64ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Aaalibaba42 · 2026-07-21T12:31:22Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-21T12:31:26Z

View all feedbacks in Devflow UI.

2026-07-21 12:31:25 UTC ℹ️ Start processing command /merge

2026-07-21 12:31:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-07-21 12:31:57 UTC ⚠️ MergeQueue: This merge request was unqueued

jules.wiriath@datadoghq.com unqueued this merge request

Aaalibaba42 · 2026-07-28T09:35:45Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-28T09:35:48Z

View all feedbacks in Devflow UI.

2026-07-28 09:35:48 UTC ℹ️ Start processing command /merge

2026-07-28 09:35:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).

2026-07-28 09:36:06 UTC ❌ MergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

#188 with merge sha 3207995

…adog (and are most likely not useful in the near/middel future in dd-trace-js)

yannham · 2026-08-11T08:50:13Z

+        debug_enabled: bool,
+    ) {
+        self.telemetry_config.set(Some(TelemetryConfig {
+            heartbeat: heartbeat_ms as u64,


Very nit: making the fact it's lossless obvious

Suggested change

heartbeat: heartbeat_ms as u64,

heartbeat: u32:from(heartbeat_ms),

Aaalibaba42 marked this pull request as ready for review July 20, 2026 16:56

Aaalibaba42 requested review from a team as code owners July 20, 2026 16:56

chatgpt-codex-connector Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread crates/pipeline/src/lib.rs Outdated

Comment thread crates/pipeline/src/lib.rs Outdated

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: waiting labels Jul 21, 2026

yannham previously approved these changes Jul 24, 2026

View reviewed changes

Comment thread crates/pipeline/src/lib.rs Outdated

Comment thread crates/pipeline/src/lib.rs Outdated

Comment thread crates/pipeline/src/lib.rs Outdated

Aaalibaba42 dismissed yannham’s stale review via 40d34eb July 27, 2026 10:13

Aaalibaba42 requested a review from yannham July 27, 2026 10:17

This comment has been minimized.

Sign in to view

yannham reviewed Jul 27, 2026

View reviewed changes

Comment thread crates/pipeline/src/lib.rs

bengl previously approved these changes Jul 27, 2026

View reviewed changes

Aaalibaba42 dismissed bengl’s stale review via ab0de16 July 27, 2026 15:24

yannham previously approved these changes Jul 27, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: removed mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected labels Jul 28, 2026

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: rejected and removed mergequeue-status: in_progress labels Jul 29, 2026

Aaalibaba42 dismissed yannham’s stale review via 53d666e August 3, 2026 09:24

Aaalibaba42 added 13 commits August 4, 2026 18:02

feat: added env capability

8246a0b

feat: respect envcapabilities method unsafedness

d6240f4

feat: validate before saying it's ok

01e760f

revert: remove set/unset since they would be dangerous APIs in libdat…

381e7eb

…adog (and are most likely not useful in the near/middel future in dd-trace-js)

chore: change input to main's commit that has the change

3f3544a

docs: update doc to remove specific references to the capabilities

5844658

fix: remove extra checks

a872df9

fix: cache env beforehand

4c45d07

feat: Adopt TraceExporter's Telemetry stuff

a595c9d

docs: fix libdatadog's behavior when 0 is passed

d2187a8

chore: js tomfoolery

72c003e

fix: comments

4adacd9

fix: use Cells uniformaly

cf9b356

Aaalibaba42 force-pushed the jwiriath/telemetry branch from 53d666e to cf9b356 Compare August 4, 2026 16:09

yannham previously approved these changes Aug 11, 2026

View reviewed changes

feat: make the losslessness obvious

c2f0eed

Aaalibaba42 dismissed yannham’s stale review via c2f0eed August 11, 2026 10:04

yannham approved these changes Aug 11, 2026

View reviewed changes

Aaalibaba42 merged commit c66c094 into main Aug 11, 2026
8 checks passed

Aaalibaba42 deleted the jwiriath/telemetry branch August 11, 2026 10:05

IlyasShabi mentioned this pull request Aug 11, 2026

v0.19.0 #200

Open

Navigation Menu

Uh oh!

feat: Adopt TraceExporter's Telemetry stuff - #183

feat: Adopt TraceExporter's Telemetry stuff#183
Aaalibaba42 merged 14 commits into
mainfrom
jwiriath/telemetry

Aaalibaba42 commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Aaalibaba42 commented Jul 21, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Aaalibaba42 commented Jul 28, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

yannham Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	heartbeat: heartbeat_ms as u64,
	heartbeat: u32:from(heartbeat_ms),

Uh oh!

Conversation

Aaalibaba42 commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Aaalibaba42 commented Jul 21, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Aaalibaba42 commented Jul 28, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yannham Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 20, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 28, 2026 •

edited

Loading