[SAASINT-5149] DDS: BlueCat Edge: Crawler Integration v1.0.0#22512
[SAASINT-5149] DDS: BlueCat Edge: Crawler Integration v1.0.0#22512apiazza-dd merged 8 commits intoDataDog:masterfrom
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffe11d369a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
drichards-87
left a comment
There was a problem hiding this comment.
Left some minor feedback from Docs and approved the PR.
| ## Setup | ||
|
|
||
| ### Configuration | ||
| ### Generate an API credentials in BlueCat Edge |
There was a problem hiding this comment.
| ### Generate an API credentials in BlueCat Edge | |
| ### Generate API credentials in BlueCat Edge |
|
|
||
| !!! Add list of steps to set up this integration !!! | ||
| 1. Log in to **BlueCat Edge** using a user with the **Analyst** role or higher. | ||
| 2. Click on **Account > Profile** tab. |
There was a problem hiding this comment.
| 2. Click on **Account > Profile** tab. | |
| 2. Click the **Account > Profile** tab. |
| 3. In the **Access key sets** section, click **New**. | ||
| 4. The **Client ID** and **Secret key** are displayed. | ||
| 5. Identify your **BlueCat Edge Domain URL** using the URL of your BlueCat Edge cloud instance. | ||
| - For example, if your BlueCat Edge cloud instance URL is **https://myBlueCat.edge.bluec.at/**, the BlueCat Edge Domain URL is **myBlueCat.edge.bluec.at**. |
There was a problem hiding this comment.
| 3. In the **Access key sets** section, click **New**. | |
| 4. The **Client ID** and **Secret key** are displayed. | |
| 5. Identify your **BlueCat Edge Domain URL** using the URL of your BlueCat Edge cloud instance. | |
| - For example, if your BlueCat Edge cloud instance URL is **https://myBlueCat.edge.bluec.at/**, the BlueCat Edge Domain URL is **myBlueCat.edge.bluec.at**. | |
| 3. In the **Access key sets** section, click **New**. The **Client ID** and **Secret key** are displayed. | |
| 4. Identify your **BlueCat Edge Domain URL** using the URL of your BlueCat Edge cloud instance. | |
| - For example, if your BlueCat Edge cloud instance URL is **https://myBlueCat.edge.bluec.at/**, the BlueCat Edge Domain URL is **myBlueCat.edge.bluec.at**. |
| ### Connect your BlueCat Edge account to Datadog | ||
|
|
||
| !!! Add steps to validate integration is functioning as expected !!! | ||
| 1. Add your `BlueCat Edge Domain`, `Client ID` and `Secret key`. |
There was a problem hiding this comment.
| 1. Add your `BlueCat Edge Domain`, `Client ID` and `Secret key`. | |
| 1. Add your `BlueCat Edge Domain`, `Client ID`, and `Secret key`. |
There was a problem hiding this comment.
Are you doing this in Datadog? If so, I might add that to the step.
There was a problem hiding this comment.
As per discussion with our PM @dpoint01, We keep this format consistent across all our integrations.
| | Parameter | Description | | ||
| | ---------- | ---------------------------------------------- | | ||
| | BlueCat Edge Domain | BlueCat Edge Domain of Instance. | | ||
| | Client ID | Client ID of BlueCat Edge. | |
There was a problem hiding this comment.
| | Client ID | Client ID of BlueCat Edge. | | |
| | Client ID | The Client ID for BlueCat Edge. | |
| | ---------- | ---------------------------------------------- | | ||
| | BlueCat Edge Domain | BlueCat Edge Domain of Instance. | | ||
| | Client ID | Client ID of BlueCat Edge. | | ||
| | Secret key | Secret key of BlueCat Edge. | |
There was a problem hiding this comment.
| | Secret key | Secret key of BlueCat Edge. | | |
| | Secret key | The secret key for BlueCat Edge. | |
| | BlueCat Edge Domain | BlueCat Edge Domain of Instance. | | ||
| | Client ID | Client ID of BlueCat Edge. | | ||
| | Secret key | Secret key of BlueCat Edge. | | ||
| | Collect NOERROR DNS Query Logs | Control the collection of NOERROR DNS Query Logs. Enabled by default. | |
There was a problem hiding this comment.
| | Collect NOERROR DNS Query Logs | Control the collection of NOERROR DNS Query Logs. Enabled by default. | | |
| | Collect NOERROR DNS Query Logs | Controls the collection of NOERROR DNS query logs. Enabled by default. | |
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Review from drichards-87 is dismissed. Related teams and files:
- documentation
- bluecat_edge/README.md
Review from apiazza-dd is dismissed. Related teams and files:
- saas-integrations
- bluecat_edge/README.md
* Add BlueCat Edge integration with assets * Resolved CI Failures * Resolved CI Failures * Minor update in dashboard and pipeline * Resolve Check Failures * Apply suggestion from @drichards-87 Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> * Updated readme --------- Co-authored-by: apiazza-dd <120594144+apiazza-dd@users.noreply.github.com> Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> 8eb38ad
| ], | ||
| "classifier_tags": [ | ||
| "Category::Log Collection", | ||
| "Category::Network", |
There was a problem hiding this comment.
Security should be another category here @bhargavnariyanicrest @apiazza-dd
* Add BlueCat Edge integration with assets * Resolved CI Failures * Resolved CI Failures * Minor update in dashboard and pipeline * Resolve Check Failures * Apply suggestion from @drichards-87 Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> * Updated readme --------- Co-authored-by: apiazza-dd <120594144+apiazza-dd@users.noreply.github.com> Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
…#22512) * Add BlueCat Edge integration with assets * Resolved CI Failures * Resolved CI Failures * Minor update in dashboard and pipeline * Resolve Check Failures * Apply suggestion from @drichards-87 Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> * Updated readme --------- Co-authored-by: apiazza-dd <120594144+apiazza-dd@users.noreply.github.com> Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> Signed-off-by: lukepatrick <lukephilips@gmail.com>
What does this PR do?
This is a initial release PR of BlueCat Edge integration including all the required assets.
Integration Logo Source: https://bluecatnetworks.com/wp-content/uploads/2024/02/bluecat-logo.svg
Additional Notes
Crawler code for this integration has been committed in its respective repo
OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour.
Review checklist (to be filled by reviewers)
Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/ label to the PR and it will automatically open a backport PR once this one is merged