add Netty epoll/NIO-select TaskBlock instrumentation - #12209
Draft
kaahos wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds TaskBlock instrumentation for NIO
Selector.selectand Netty epoll event-loop blocking, following the same pattern established for LockSupport (#11545) and Thread.sleep (#11546). Includes:nio-selectandnetty-epoll-4.1instrumentation modulesNioSelectTaskBlockProfilingTest,NettyEpollTaskBlockProfilingTest) asserting on resulting TaskBlock recordingsNativeIoTaskBlockProfilingTest)This is stacked on #11546 (Thread.sleep), #11545 (LockSupport), and #11544 (foundational TaskBlock support), and should be reviewed/merged in that order.
Motivation
Selector-based I/O waits and Netty's epoll event loop are common sources of off-CPU time that for now show up only as generic sampled wall-clock frames. Emitting structured
datadog.TaskBlockevents for these operations, as already done for locks and sleeps, gives users accurate attribution of NIO and Netty event-loop blocking without relying solely on stack sampling.Additional Notes
.gitlab-ci.yml) updated to build/track the correspondingjava-profilerTaskBlock branch changes needed for this coverage.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]