-
Notifications
You must be signed in to change notification settings - Fork 352
Unify OkHttp dependency catalog entries #12201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,8 @@ tabletest-formatter = "1.1.2" | |
| # DataDog libs and forks | ||
| ddprof = "1.49.0" | ||
| dogstatsd = "4.4.5" | ||
| okhttp = "3.12.15" # Datadog fork to support Java 7 | ||
| okhttp-datadog = "3.12.15" # Datadog fork | ||
| okio-datadog = "1.17.6" # Datadog fork | ||
|
|
||
| # Languages | ||
| ## Groovy | ||
|
|
@@ -51,8 +52,8 @@ jafar = "0.16.0" | |
|
|
||
| # Web & Network | ||
| jnr-unixsocket = "0.38.25" | ||
| okhttp-legacy = "[3.0,3.12.12]" # 3.12.x is last version to support Java7 | ||
| okio = "1.17.6" # Datadog fork | ||
| okhttp2-minimum = "2.2.0" | ||
| okhttp3-minimum = "3.0.0" | ||
|
Comment on lines
+55
to
+56
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔨 issue: okhttp2-minimum / okhttp3-minimum versions and libraries are instrumentation specific. I would rather keep the main version catalog for core and platform components. |
||
|
|
||
| # Cryptography | ||
| cafe_crypto = "0.1.0" | ||
|
|
@@ -75,12 +76,13 @@ moshi = "1.11.0" | |
|
|
||
| # Testing | ||
| assertj = "3.27.7" | ||
| json-unit = "2.40.1" | ||
| junit4 = "4.13.2" | ||
| junit5 = "5.14.1" | ||
| junit-platform = "1.14.1" | ||
| mockito = "4.4.0" | ||
| okhttp3-testing = "3.12.12" | ||
| spock = "2.4-groovy-3.0" | ||
| json-unit = "2.40.1" | ||
| tabletest = "1.2.2" | ||
| testcontainers = "1.21.4" | ||
|
|
||
|
|
@@ -95,7 +97,8 @@ spotbugs-annotations = { module = "com.github.spotbugs:spotbugs-annotations", ve | |
| # DataDog libs and forks | ||
| ddprof = { module = "com.datadoghq:ddprof", version.ref = "ddprof" } | ||
| dogstatsd = { module = "com.datadoghq:java-dogstatsd-client", version.ref = "dogstatsd" } | ||
| okhttp = { module = "com.datadoghq.okhttp3:okhttp", version.ref = "okhttp" } | ||
| okhttp-datadog = { module = "com.datadoghq.okhttp3:okhttp", version.ref = "okhttp-datadog" } | ||
| okio-datadog = { module = "com.datadoghq.okio:okio", version.ref = "okio-datadog" } | ||
|
|
||
| # Languages | ||
| ## Groovy | ||
|
|
@@ -133,7 +136,6 @@ jmc-flightrecorder = { module = "org.openjdk.jmc:flightrecorder", version.ref = | |
| jafar-tools = { module = "io.btrace:jafar-tools", version.ref = "jafar" } | ||
|
|
||
| # Web & Network | ||
| okio = { module = "com.datadoghq.okio:okio", version.ref = "okio" } | ||
| jnr-unixsocket = { module = "com.github.jnr:jnr-unixsocket", version.ref = "jnr-unixsocket"} | ||
|
|
||
| # Cryptography | ||
|
|
@@ -162,6 +164,10 @@ slf4j = { module = "org.slf4j:slf4j-api", version.ref = "slf4j" } | |
| jackson-databind = {module = "com.fasterxml.jackson.core:jackson-databind", version.ref = "jackson"} | ||
| moshi = { module = "com.squareup.moshi:moshi", version.ref = "moshi" } | ||
|
|
||
| # Web & Network | ||
| okhttp2-minimum = { module = "com.squareup.okhttp:okhttp", version.ref = "okhttp2-minimum" } | ||
| okhttp3-minimum = { module = "com.squareup.okhttp3:okhttp", version.ref = "okhttp3-minimum" } | ||
|
|
||
| # Testing | ||
| assertj-core = { module = "org.assertj:assertj-core", version.ref = "assertj" } | ||
| json-unit-assertj = { module = "net.javacrumbs.json-unit:json-unit-assertj", version.ref = "json-unit" } | ||
|
|
@@ -172,6 +178,7 @@ junit-jupiter-engine = { module = "org.junit.jupiter:junit-jupiter-engine", vers | |
| junit-platform-launcher = { module = "org.junit.platform:junit-platform-launcher", version.ref = "junit-platform" } | ||
| mokito-core = { module = "org.mockito:mockito-core", version.ref = "mockito" } | ||
| mokito-junit-jupiter = { module = "org.mockito:mockito-junit-jupiter", version.ref = "mockito" } | ||
| okhttp3-mockwebserver = { module = "com.squareup.okhttp3:mockwebserver", version.ref = "okhttp3-testing" } | ||
| objenesis = { module = "org.objenesis:objenesis", version = "3.3" } # Used by Spock for mocking: | ||
| spock-core = { module = "org.spockframework:spock-core", version.ref = "spock" } | ||
| spock-junit4 = { module = "org.spockframework:spock-junit4", version.ref = "spock" } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A future catalog bump could stop testing an advertised minimum and allow newer API usage that fails for customers on that version.
Assertion details
okhttp3-minimumorokhttp2-minimumfor the smoke-test applications without intending to change instrumentation support.Per the repository’s explicit Gradle guidance, instrumented-library compatibility floors should remain exact and local to each instrumentation module.3.0.0values for OkHttp 3 compile/strict/preferred bounds and local2.2.0values for both OkHttp 2 declarations; existing test sources need no changes because the minimum/latest suites already exercise these boundaries.Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest