Skip to content

Deduplicate GitLab test job templates - #12199

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/deduplicate-arm64-gitlab-tests
Aug 24, 2026
Merged

Deduplicate GitLab test job templates#12199
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/deduplicate-arm64-gitlab-tests

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

  • Extracts shared GitLab test-job setup into .test_job_common for AMD64 and ARM64 jobs.
  • Deduplicates the test-agent service configuration used by both architectures.
  • Keeps ARM64 jobs gated on the AMD64 build job without downloading its platform-specific artifacts.
  • Keeps the ARM64 default JVM subset manual on feature branches while retaining the full ARM64 matrix on merge queue and master.

Motivation

The ARM64 test templates duplicated most of the AMD64 Gradle setup, scripts, report collection, artifacts, retries, and test-agent configuration. That duplication made the architectures prone to drifting whenever shared CI setup changed and made rebases unnecessarily conflict-prone.

Sharing the common template keeps both architectures aligned. The AMD64 build gate also avoids spending ARM64 runner capacity on commits that do not compile.

Additional Notes

  • ARM64 jobs remain non-blocking while stability data is collected.
  • IBM Java 8 remains excluded because no ARM64 image is available; Oracle Java 8 remains excluded because it is too flaky for CI.
  • Relevant precedents: #11364, #11470, and #11835.
  • Validation: local YAML parsing and git diff --check passed; the repository commit hook completed its Gradle/Spotless checks successfully (6,534 tasks).

Contributor Checklist

Jira ticket: N/A

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added comp: tooling Build & Tooling type: refactoring tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Aug 12, 2026 — with ChatGPT Codex Connector
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Aug 12, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review August 12, 2026 14:45
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners August 12, 2026 14:45
@datadog-prod-us1-3

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.94 s 14.75 s [+0.7%; +2.0%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.78 s 13.74 s [-0.6%; +1.3%] (no difference)
startup:petclinic:appsec:Agent 16.94 s 16.76 s [+0.1%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 16.93 s 17.02 s [-1.3%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.67 s 16.85 s [-2.2%; +0.1%] (no difference)
startup:petclinic:sca:Agent 16.91 s 16.62 s [+0.8%; +2.7%] (maybe worse)
startup:petclinic:tracing:Agent 16.01 s 16.20 s [-2.1%; -0.3%] (maybe better)

Commit: c66ced75 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Expanded job behavior preserves AMD64 and ARM64 architecture contracts, including test-agent checks, coverage composition, JVM exclusions, manual feature-branch rules, and the intended artifact-free ARM64 build gate.

Was this helpful? React 👍 or 👎

📊 Validated against 6 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit e243804 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd make the architecture explicit in amd64 jobs, so there's a consistent job naming.

My comments are not exhaustive, so there might be other places where this applies.

Comment thread .gitlab-ci.yml Outdated
Comment thread .gitlab-ci.yml
Comment thread .gitlab-ci.yml Outdated
Comment thread .gitlab-ci.yml
@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 24, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-24 20:32:05 UTC ℹ️ Start processing command /merge


2026-08-24 20:32:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-24 21:27:25 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit a040e7c into master Aug 24, 2026
591 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/deduplicate-arm64-gitlab-tests branch August 24, 2026 21:27
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants