Skip to content

chore: add ClassDefining tests#11644

Open
mcculls wants to merge 1 commit into
masterfrom
mcculls/ignore-duplicate-observer-calls
Open

chore: add ClassDefining tests#11644
mcculls wants to merge 1 commit into
masterfrom
mcculls/ignore-duplicate-observer-calls

Conversation

@mcculls

@mcculls mcculls commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Add ClassDefining tests and ignore extraneous observer calls.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: APMSP-3229

@mcculls mcculls requested a review from a team as a code owner June 14, 2026 16:28
@mcculls mcculls added the comp: core Tracer core label Jun 14, 2026
@mcculls mcculls requested a review from amarziali June 14, 2026 16:28
@mcculls mcculls added tag: no release notes Changes to exclude from release notes type:chore labels Jun 14, 2026
@mcculls mcculls force-pushed the mcculls/ignore-duplicate-observer-calls branch from b00e22c to 6fb5298 Compare June 14, 2026 16:39
@mcculls mcculls changed the title chore: ignore duplicate calls to set observer chore: add tests around class observer Jun 14, 2026
@mcculls mcculls changed the title chore: add tests around class observer chore: add ClassDefining tests Jun 14, 2026
@mcculls mcculls force-pushed the mcculls/ignore-duplicate-observer-calls branch from 6fb5298 to 162017f Compare June 14, 2026 16:42
@datadog-prod-us1-4

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.92 s 13.92 s [-0.8%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.89 s 12.98 s [-1.5%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 16.75 s 16.13 s [-0.5%; +8.2%] (no difference)
startup:petclinic:iast:Agent 16.87 s 16.33 s [-1.2%; +7.9%] (no difference)
startup:petclinic:profiling:Agent 16.89 s 16.87 s [-1.0%; +1.2%] (no difference)
startup:petclinic:sca:Agent 16.89 s 16.73 s [+0.1%; +1.8%] (maybe worse)
startup:petclinic:tracing:Agent 16.07 s 16.07 s [-0.9%; +0.9%] (no difference)

Commit: 162017f5 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type:chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant