Skip to content

Allow Trailing ; in DD Header for W3C tracestate#11632

Open
mhlidd wants to merge 3 commits into
masterfrom
mhlidd/update_tracestate_parsing
Open

Allow Trailing ; in DD Header for W3C tracestate#11632
mhlidd wants to merge 3 commits into
masterfrom
mhlidd/update_tracestate_parsing

Conversation

@mhlidd

@mhlidd mhlidd commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Previously, the Java tracer dropped all DD headers that had trailing ; in the W3C tracestate. This is inconsistent behavior from other Datadog tracers, which allowed this behavior. This PR updates the Java tracer behavior to be consistent with other tracers by allowing the trailing ; and trailing ; followed by trailing whitespaces.

Motivation

This PR fixes a bug reported in #11395

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@datadog-prod-us1-4

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 13.90 s [-0.5%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.90 s 12.98 s [-1.4%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.93 s 16.51 s [+1.5%; +3.5%] (significantly worse)
startup:petclinic:iast:Agent 16.90 s 16.95 s [-1.2%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 16.88 s 16.51 s [-2.3%; +6.8%] (no difference)
startup:petclinic:sca:Agent 16.89 s 16.22 s [-0.3%; +8.6%] (no difference)
startup:petclinic:tracing:Agent 15.71 s 16.13 s [-6.6%; +1.5%] (no difference)

Commit: 5b5dea17 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mhlidd

mhlidd commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b1937bb2e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mhlidd

mhlidd commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 2e846af0a7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mhlidd mhlidd changed the title init Allow Trailing ; in W3C tracestate Jun 12, 2026
@mhlidd mhlidd changed the title Allow Trailing ; in W3C tracestate Allow Trailing ; in DD Header for W3C tracestate Jun 12, 2026
@mhlidd mhlidd added type: bug Bug report and fix type: enhancement Enhancements and improvements comp: context propagation Trace context propagation labels Jun 12, 2026
@mhlidd mhlidd marked this pull request as ready for review June 12, 2026 17:40
@mhlidd mhlidd requested review from a team as code owners June 12, 2026 17:40
@mhlidd mhlidd requested review from PerfectSlayer and mtoffl01 and removed request for a team June 12, 2026 17:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e846af0a7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mhlidd

mhlidd commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 5b5dea17a5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: context propagation Trace context propagation type: bug Bug report and fix type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant