Fix CodeOrigin for interface endpoints#11017
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom Apr 3, 2026
Merged
Fix CodeOrigin for interface endpoints#11017gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
If endpoints are declared in interface with annotations, CodeOrigin instrumentation does not trigger and no code origin information are added to spans. We need to match also this case to trigger creation of code origin probe for handler in the concrete class implementing the interface Added smoke tests to cover those cases for Spring apps
jpbempel
force-pushed
the
jpbempel/fix-interface-endpoints
branch
from
725abc1 to
1271b9d
Compare
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
jpbempel
added
comp: debugger
interface support add overhead at startup so need to be manually enabled
amarziali
approved these changes
Apr 2, 2026
Contributor
amarziali
left a comment
amarziali
left a comment
There was a problem hiding this comment.
ok for the apm-java owned part (configurations)
evanchooly
approved these changes
Apr 3, 2026
| @@ -50,9 +50,8 @@ public final class ConfigDefaults { | |||
| static final boolean DEFAULT_WRITER_BAGGAGE_INJECT = true; | |||
| static final String DEFAULT_SITE = "datadoghq.com"; | |||
|
|
|||
| static final boolean DEFAULT_CODE_ORIGIN_FOR_SPANS_ENABLED = false; | |||
Contributor
There was a problem hiding this comment.
just replacing this because code origin is default on now and we don't need it?
Member
Author
There was a problem hiding this comment.
this driven by
now
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
bot
deleted the
jpbempel/fix-interface-endpoints
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
If endpoints are declared in interface with annotations, CodeOrigin instrumentation does not trigger and no code origin information are added to spans.
We need to match also this case to trigger creation of code origin probe for handler in the concrete class implementing the interface Added smoke tests to cover those cases for Spring apps
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5372
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.