[SVLS-9373] fix(config): trim trailing slashes from DD URL env vars#1298
Open
shreyamalpani wants to merge 3 commits into
Open
[SVLS-9373] fix(config): trim trailing slashes from DD URL env vars#1298shreyamalpani wants to merge 3 commits into
shreyamalpani wants to merge 3 commits into
Conversation
Contributor
|
duncanista
reviewed
Jul 7, 2026
duncanista
approved these changes
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Bottlecap’s pinned upstream configuration dependencies so that DD_URL, DD_DD_URL, and DD_APM_DD_URL inputs are normalized (trailing slashes trimmed) before being used to build intake URLs, preventing URL prefix validation failures and panics in metrics flusher initialization.
Changes:
- Bumped
serverless-components(includingdatadog-agent-configanddogstatsd) to a revision that trims trailing slashes for relevantDD_*_URLenv vars. - Bumped
libdatadoggit pins to a matching revision and updated the lockfile accordingly. - Added unit tests in Bottlecap config parsing to ensure
DD_URLandDD_DD_URLwith trailing slashes remain parseable after normalization.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bottlecap/src/config/mod.rs | Adds regression tests for DD_URL/DD_DD_URL trailing-slash normalization behavior. |
| bottlecap/Cargo.toml | Updates git revisions for serverless-components and libdatadog dependencies. |
| bottlecap/Cargo.lock | Refreshes the dependency graph to reflect updated git pins and transitive version changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
DD_URL,DD_DD_URL, andDD_APM_DD_URLwere not trimming trailing slashes before being used to build intake URLs. This caused failures such as failingdogstatsd'sDdUrl/DdDdUrlprefix validation, panicking withcan't parse DD_DD_URL: UrlPrefixError(...)instart_metrics_flushers.The fix lives upstream in
datadog-agent-config: DataDog/serverless-components#142.This PR bumps bottlecap's
serverless-componentspin to the merged fix commit, and bumps bottlecap's own directlibdatadogpins to match.Motivation
SVLS-9373
Testing