[APPS][WIP] Initialize Datadog Apps backend runtime - #459
Draft
sdkennedy2 wants to merge 1 commit into
Draft
Conversation
sdkennedy2
changed the title
Collaborator
Author
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Initialize the runtime behind
@datadog/apps-backendwithout exposing thejsFunctionWithActions$context to customer backend functions.This is the runtime half of DataDog/web-ui#331310, which introduces the published package and its customer-facing
getCurrentUser()API.How?
The Apps plugin conditionally resolves the package's exported
runtime/js-function-with-actionsadapter subpath. When installed, the generated virtual entry imports the runtime setter and adapter, then installs the runtime from$at the beginning ofmainbefore customer code executes.Projects without
@datadog/apps-backendretain byte-for-byte equivalent runtime behavior aside from the package-resolution check. Focused tests cover conditional imports, initialization ordering, setup from the invocation context, and unchanged dev/production entry generation.