Skip to content

Innovation Week POC: Live Debugger browser support#4004

Closed
watson wants to merge 16 commits intoDataDog:live-debugger-inno-weekfrom
watson:watson/debugger-code
Closed

Innovation Week POC: Live Debugger browser support#4004
watson wants to merge 16 commits intoDataDog:live-debugger-inno-weekfrom
watson:watson/debugger-code

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Dec 5, 2025

No description provided.

@watson watson requested a review from a team as a code owner December 5, 2025 19:43
@watson watson force-pushed the watson/debugger-code branch 5 times, most recently from f96d981 to c1de598 Compare December 5, 2025 21:54
It should probably live somewhere else, but for now I've just hardcoded
it in the sandbox app as a starting point
@watson watson force-pushed the watson/debugger-code branch from c1de598 to 102a611 Compare December 5, 2025 22:26
@watson watson requested a review from a team as a code owner December 6, 2025 10:45
@watson watson changed the title ✨ Add live debugger integration and configuration options Innovation Week POC: Live Debugger browser support Dec 6, 2025
@watson watson force-pushed the watson/debugger-code branch from 1365737 to 4177de3 Compare December 6, 2025 10:53
@watson watson force-pushed the watson/debugger-code branch 4 times, most recently from 4a453f7 to b9b2fb2 Compare December 6, 2025 16:33
@watson watson force-pushed the watson/debugger-code branch from b9b2fb2 to 2a06d8a Compare December 6, 2025 16:34
@watson watson force-pushed the watson/debugger-code branch 2 times, most recently from e013a4d to 9fa4ebf Compare December 7, 2025 22:55
@watson watson force-pushed the watson/debugger-code branch 3 times, most recently from 0b4dea7 to 3b3235f Compare December 8, 2025 10:52
@watson watson force-pushed the watson/debugger-code branch from 3b3235f to 7399fd1 Compare December 8, 2025 12:27
@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Dec 8, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex bot commented Dec 8, 2025

View all feedbacks in Devflow UI.

2025-12-08 19:50:49 UTC ℹ️ Start processing command /merge


2025-12-08 19:50:55 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in live-debugger-inno-week is approximately 0s (p90).


2025-12-08 19:51:22 UTC ⚠️ MergeQueue: This merge request build was cancelled

thomas.watson@datadoghq.com cancelled this merge request build

@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Dec 8, 2025

/merge --cancel

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex bot commented Dec 8, 2025

View all feedbacks in Devflow UI.

2025-12-08 19:51:16 UTC ℹ️ Start processing command /merge --cancel

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@watson watson force-pushed the watson/debugger-code branch from 011c2f8 to cd26a35 Compare December 9, 2025 14:14
@ahfuckit
Copy link
Copy Markdown

_ No description provided. _
edited from
It should probably live somewhere else, but for now I've just hardcoded it in the sandbox app as a starting point

Why? Somewhere less obvious? Don't want to get caught?

@thomas-lebeau
Copy link
Copy Markdown
Collaborator

@watson, in order to better keep track of PRs that need our attention, I'm gonna convert this PR to draft.

@thomas-lebeau thomas-lebeau marked this pull request as draft March 3, 2026 07:48
@watson watson marked this pull request as ready for review March 13, 2026 10:53
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd26a35847

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +85 to +87
if (
start - probe.lastCaptureMs < probe.msBetweenSampling ||
!checkGlobalSnapshotBudget(start, probe.captureSnapshot)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move sampling checks after condition evaluation

The sampling gate runs before any condition is evaluated, so a probe call with a false condition still consumes snapshot budget and advances the probe’s sampling window. In onEntry, this means high-frequency false evaluations can throttle later true evaluations and silently drop snapshots that should have been captured.

Useful? React with 👍 / 👎.

const stackLines = error.stack.split('\n')

// Skip the first line (error message), the captureStackTrace frame, and any additional frames to skip
for (let i = 2 + skipFrames; i < stackLines.length; i++) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Start parseStackTrace at first real frame for thrown errors

parseStackTrace always skips two lines, which is only correct for internally created errors in captureStackTrace; when called with a real thrown error (onThrow uses parseStackTrace(error)), it drops the top stack frame where the exception actually originated. This reduces snapshot accuracy by removing the most relevant frame.

Useful? React with 👍 / 👎.

// Cache hostname at module initialization since it won't change during the app lifetime
const hostname = typeof window !== 'undefined' && window.location ? window.location.hostname : 'unknown'

const serviceVersion = `1.0.0-${crypto.randomUUID().slice(0, 8)}` // eslint-disable-line local-rules/disallow-side-effects
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add fallback when crypto.randomUUID is unavailable

This module initializes serviceVersion with crypto.randomUUID() at import time, so environments that lack randomUUID (common in older Safari/Chromium builds and many embedded WebViews) will throw before init() can run. That makes the live debugger fail to load entirely in those clients.

Useful? React with 👍 / 👎.

@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Mar 13, 2026

This PR currently points to the branch of this PR: #3996

I think we're ready to land both this PR that the one it's point to, so work can continue in incremental PRs towards the main branch instead of being contained in a single huge PR.

@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Mar 13, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 13, 2026

View all feedbacks in Devflow UI.

2026-03-13 11:24:32 UTC ℹ️ Start processing command /merge


2026-03-13 11:24:33 UTC ℹ️ MergeQueue: Stack detected — automatically merging the entire stack.

@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Mar 13, 2026

This seems to have been detected as a stack PR by the Merge Queue, so I will instead close this PR and make a new PR that's the sum of these two PRs.

@watson watson closed this Mar 13, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants