Skip to content

Fix irregular whitespace for MetadataRepresentationListComponent#5665

Open
alexandrevryghem wants to merge 2 commits into
DSpace:mainfrom
alexandrevryghem:w2p-141473_fix-irregular-whitespace-for-MetadataRepresentationListComponent_contribute-main
Open

Fix irregular whitespace for MetadataRepresentationListComponent#5665
alexandrevryghem wants to merge 2 commits into
DSpace:mainfrom
alexandrevryghem:w2p-141473_fix-irregular-whitespace-for-MetadataRepresentationListComponent_contribute-main

Conversation

@alexandrevryghem
Copy link
Copy Markdown
Member

Description

Removed the trailing whitespace below the MetadataRepresentationListComponent when the page size is smaller than 10. Also reduced the spacing below the load more/hide last buttons to match the default spacing between item page fields.

Instructions for Reviewers

List of changes in this PR:

  • Hide the mt-2 spacing from the load more/hide last buttons when the page size is smaller than 10
  • Replaced the float-start & float-end styling on the load more/hide last buttons with flex box with justify-content: between. This will remove the additional spacing generated by the float logic underneath the buttons.
  • Made the separator for this item page field configurable as well

Guidance for how to test and review this PR:

  • Create a publication with 1 author
    • Verify that the spacing between the authors field & the next field is now the same as the other fields:
      imageimage
  • Create a publication with 10+ authors
    • Verify that the spacing between the authors field & the next field is now the same as the other fields:
      imageimage

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

…ntationListComponent_contribute-9.0' into w2p-141473_fix-irregular-whitespace-for-MetadataRepresentationListComponent_contribute-main
@alexandrevryghem alexandrevryghem self-assigned this May 15, 2026
@alexandrevryghem alexandrevryghem added component: Item (Archived) Item display or editing ux User Experience related works port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels May 15, 2026
@lgeggleston lgeggleston added improvement 1 APPROVAL pull request only requires a single approval to merge labels May 15, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 15, 2026
Copy link
Copy Markdown

@nathanmlf nathanmlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alexandrevryghem! I've tested it on my side and everything seems to be working as expected. I will attach some screenshots below for comparison:

One author test (Sandbox):

Image

One author test (PR-5665):

Image

Ten authors test (Sandbox):

Image

Ten authors test (PR-5665):

Image

Nice job with the improvement!

@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release May 20, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandrevryghem : I'm finding that this PR fixes some things, but makes other displays slightly worse??

For example, here's what I see for the same Publication on http://sandbox.dspace.org (without this PR), and on my local machine (with this PR) and on my local machine without this PR.

The Sandbox display looks the best. The behavior with this PR looks decent, but doesn't work if an author has an ORCID next to it. If I remove your PR from my local machine, then authors are jumbled (which doesn't look great either). I'm trying to figure out why I'm seeing three different displays, but it must be based on which features are enabled.

Sandbox display: (See https://sandbox.dspace.org/entities/publication/f3edcd34-ed72-43eb-9594-77c206636540)

Image

This PR's display:

Image

My local machine without this PR:

Image

Overall, this PR seems like it's an improvement, but it's a bit buggy if the authors have an ORCID identifier.

Finally, I did want to note that this PR seems to be a fix for #5519 (which is the bug you see in my local display above) and therefore seems to have an overlap with #5540

@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to 👀 Under Review in DSpace 10.0 Release May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: Item (Archived) Item display or editing improvement port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release ux User Experience related works

Projects

Status: 👀 Under Review

Development

Successfully merging this pull request may close these issues.

4 participants