Fix irregular whitespace for MetadataRepresentationListComponent#5665
Conversation
…ntationListComponent_contribute-9.0' into w2p-141473_fix-irregular-whitespace-for-MetadataRepresentationListComponent_contribute-main
nathanmlf
left a comment
There was a problem hiding this comment.
Hey @alexandrevryghem! I've tested it on my side and everything seems to be working as expected. I will attach some screenshots below for comparison:
One author test (Sandbox):
One author test (PR-5665):
Ten authors test (Sandbox):
Ten authors test (PR-5665):
Nice job with the improvement!
There was a problem hiding this comment.
@alexandrevryghem : I'm finding that this PR fixes some things, but makes other displays slightly worse??
For example, here's what I see for the same Publication on http://sandbox.dspace.org (without this PR), and on my local machine (with this PR) and on my local machine without this PR.
The Sandbox display looks the best. The behavior with this PR looks decent, but doesn't work if an author has an ORCID next to it. If I remove your PR from my local machine, then authors are jumbled (which doesn't look great either). I'm trying to figure out why I'm seeing three different displays, but it must be based on which features are enabled.
Sandbox display: (See https://sandbox.dspace.org/entities/publication/f3edcd34-ed72-43eb-9594-77c206636540)
This PR's display:
My local machine without this PR:
Overall, this PR seems like it's an improvement, but it's a bit buggy if the authors have an ORCID identifier.
Finally, I did want to note that this PR seems to be a fix for #5519 (which is the bug you see in my local display above) and therefore seems to have an overlap with #5540
Description
Removed the trailing whitespace below the
MetadataRepresentationListComponentwhen the page size is smaller than 10. Also reduced the spacing below the load more/hide last buttons to match the default spacing between item page fields.Instructions for Reviewers
List of changes in this PR:
mt-2spacing from the load more/hide last buttons when the page size is smaller than 10float-start&float-endstyling on the load more/hide last buttons with flex box withjustify-content: between. This will remove the additional spacing generated by the float logic underneath the buttons.Guidance for how to test and review this PR:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.