fix: hide admin sidebar when user has no admin permissions (#4770)#5291
Open
jaredgalanis wants to merge 2 commits intoDSpace:mainfrom
Open
fix: hide admin sidebar when user has no admin permissions (#4770)#5291jaredgalanis wants to merge 2 commits intoDSpace:mainfrom
jaredgalanis wants to merge 2 commits intoDSpace:mainfrom
Conversation
Admin sidebar menu providers (New, Edit, Import, Export, Access Control) had their top-level sections set to visible: true unconditionally. This caused the sidebar to render for all authenticated users, even those with no admin permissions, showing an empty sidebar with only the pin/unpin toggle. Fix by gating each provider's top section visibility on the same authorization checks used by their subsections, matching the pattern already used by NotificationsMenuProvider and CoarNotifyMenuProvider.
lgeggleston
added
bug
component: administrative tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Admin sidebar menu providers (New, Edit, Import, Export, Access Control, Registries) had their top-level sections set to
visible: trueunconditionally. This caused thesidebar to render for all authenticated users, even those with no admin permissions, showing an empty sidebar with only the pin/unpin toggle.
Each provider's
getTopSection()now gates visibility on the same authorization checks used by their subsections, matching the pattern already used byNotificationsMenuProviderandCoarNotifyMenuProvider.Instructions for Reviewers
List of changes in this PR:
NewMenuProvidertop section visibility gated onIsCollectionAdmin || IsCommunityAdmin || AdministratorOf || CanSubmit || CoarNotifyEnabledEditMenuProvidertop section visibility gated onIsCollectionAdmin || IsCommunityAdmin || CanEditItemImportMenuProvidertop section visibility gated onAdministratorOfExportMenuProvidertop section visibility gated onAdministratorOfAccessControlMenuProvidertop section visibility gated onAdministratorOf || CanManageGroupsRegistriesMenuProvidertop section visibility gated onAdministratorOfHow to test:
Checklist
mainbranchnpm run lintnpm run check-circ-deps)