feat: add input/output sandbox download support#353
Merged
aldbr merged 1 commit intoDIRACGrid:mainfrom Mar 18, 2026
Merged
Conversation
aldbr
force-pushed
the
main_FEAT_sandboxes
branch
from
5d9b442 to
5981d1e
Compare
aldbr
force-pushed
the
main_FEAT_sandboxes
branch
from
5981d1e to
acce43d
Compare
aldbr
force-pushed
the
main_FEAT_sandboxes
branch
from
acce43d to
55a34dd
Compare
ryuwd
reviewed
Mar 18, 2026
| diracxUrl: string | null, | ||
| jobId: number, | ||
| sbType: "input" | "output", | ||
| accessToken: string, |
Contributor
There was a problem hiding this comment.
unrelated to this PR because this is the currently adopted pattern but I think we have to do something about OIDC fetching and auth in general because having and passing the access token into the fetchers and around like this is not ideal.
At least the access token should be fetched and substituted into a utility fetch function defined in one place and supplied from a hook, where this hook is used everywhere in the specific data fetchers. We can use useSWR to build data fetchers, and we can provide special utility functions for doing POSTs. In an ideal world we never touch access tokens in the browser anyway...
I will make an issue about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #220
But first, I think it would be best to merge #349
Note: there is no support for nested menus in MUI at the moment (this is expected to come "soon")