Autoclothing fix#5840
Open
LightHardt wants to merge 2 commits into
Open
Conversation
player for the armorFlagsMatch function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When printing out the values of variables along the path for validating the material type I saw that
requirement.material_category.wholewas 0. So in thearmorFlagsMatchfunction it was trying to check bits that weren't set. From a quick look over it seemed the purpose is just to check that the user specified a material that is valid for the armor wanted. With this in mind I passed in the material_category that the user wants and in game was able to get the desired behavior of creating orders of cloth gloves. I also saw the desired behavior of invalid material type when i tried ordering wood gloves.This tries to fix #5837, please let me know if any issues