Skip to content

fix: multiple cortex engine bugs (permissions, markdown, turn_count) #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
redlittenyoth wants to merge 4 commits into from
Closed

fix: multiple cortex engine bugs (permissions, markdown, turn_count) #142

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2c6b9e
fix(permission): honor parent permissions in can_load_skill
redlittenyoth Feb 13, 2026
df0d54d
fix(capture): use 4 backticks for code blocks to prevent escaping
redlittenyoth Feb 13, 2026
04e4956
Fix turn_count desync in Conversation (#8881)
Feb 13, 2026
ffd5a7b
fix(core): resolve re-entrant deadlock, DNS security flaw, and LSP do…
Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions src/cortex-engine/src/permission/skill_permissions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,33 @@ impl SkillPermissionChecker {
///
/// This checks the permission to load and execute a skill.
pub async fn can_load_skill(&self, skill_name: &str) -> Result<bool> {
let response = self
.permission_manager
.check_skill_permission(skill_name)
.await;
let response = self.permission_manager.check_skill_permission(skill_name).await;

// If parent inheritance is enabled and current manager doesn't allow,
// check parent
let final_response = if response == PermissionResponse::Ask
&& self.inherit_parent_permissions
&& self.parent_manager.is_some()
{
if let Some(ref parent) = self.parent_manager {
let parent_response = parent.check_skill_permission(skill_name).await;
if parent_response == PermissionResponse::Allow {
parent_response
} else {
response
}
} else {
response
}
} else {
response
};

let decision = SkillPermissionDecision::new(
skill_name,
None,
response,
match response {
final_response,
match final_response {
PermissionResponse::Allow => "Skill loading allowed",
PermissionResponse::Deny => "Skill loading denied",
PermissionResponse::Ask => "Skill loading requires user confirmation",
Expand All @@ -194,7 +211,7 @@ impl SkillPermissionChecker {

self.log_decision(decision).await;

match response {
match final_response {
PermissionResponse::Allow => {
info!(skill = skill_name, "Skill loading permitted");
Ok(true)
Expand Down Expand Up @@ -535,3 +552,4 @@ mod tests {
assert!(!decisions.is_empty());
}
}