-
Notifications
You must be signed in to change notification settings - Fork 34
Make not slow #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Make not slow #456
Conversation
costowell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge, ship it
| app.wsgi_app, | ||
| restrictions=[30] | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like if this is worth documenting, its worth having an environment variable to enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's so true
i'll do that
What
Improves various logic to speed up loading conditional, especially dashboard
On CSH ethernet
Before: 6.3 seconds
After: 1.4 seconds
On VPN to my home in state college PA (central)
Before: 6.5 seconds
After: 1.5 seconds
(After I thought about this, not sure if the vpn test is doing what I want because I would've thought that I couldn't reach the db since I wouldn't have been on cshnet but idk)
Spring evals page
Before: 35 seconds
After: 1.3 seconds 🎉
Note: I want to profile these on OKD at some point but I have to figure out how to
Why
Conditional was painfully slow to load before, especially when loading a fresh instance, also on okd spring evals was 504ing
Test Plan
Compared all the various stats on dashboard with both spring and fall semester data
What I checked:
/housing)Env Vars
nope
Checklist