Draft
Conversation
| methods | ||
| function obj = Canonical(varargin) | ||
|
|
||
| load('mesh4000.mat', 'lambda', 'phi'); |
Member
There was a problem hiding this comment.
Seems strange that the meshfree shallow water is loading a mesh
Comment on lines
8
to
16
| H = 5.768e4; | ||
| % earth gravity | ||
| g = 9.8; | ||
| % radius of the earth | ||
| a = 6.370e6; | ||
| % initial velocity | ||
| u0 = 20; | ||
| % Angular speed of the earth | ||
| Omega = 7.292e-5; |
Member
There was a problem hiding this comment.
Can use otp.utils.PhysicalConstants
|
|
||
| %% Do the rest | ||
|
|
||
| oneday = 24*60*60; |
Member
There was a problem hiding this comment.
Can use otp.utils.PhysicalConstants
Comment on lines
112
to
114
| obj.PlottingInterp = Wplot; | ||
| obj.PlottingLatitude = plotlatitude; | ||
| obj.PlottingLongitude = plotlongitude; |
Member
There was a problem hiding this comment.
These should be computed in a plot function to narrow their scope
|
|
||
| methods | ||
|
|
||
| function plotSphere(obj, huv, projection) |
Member
There was a problem hiding this comment.
Inconsistent passing of axes to plotting functions
…d work with significantly less points
|
|
||
| coriolisForce = 2*Omega*z; | ||
|
|
||
| params = struct; |
| params.rbf = @otp.utils.rbf.buhmann3; | ||
|
|
||
| % convert from Cartesian to spherical coordinates | ||
| theta = atan2(z, sqrt(x.^2 + y.^2)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a meshfree method. It is not yet ready to merge, but I wanted to get something up just in case I start using it soon.