Flipped default Settings Card Action Icon in RTL contexts#855
Open
Avid29 wants to merge 1 commit into
Open
Conversation
Avid29
added
bug
Avid29
changed the title
Avid29
changed the title
Avid29
changed the title
Collaborator
|
@Avid29 ActionIcon can be changed by the developer to pretty much any ic9n. I eonder if in some, or most uses cases, you do not want that icon to be flipped. Is there an event where we detect RTL and we check if the default glyph is set and if so we set the RTL version of the glyph instead? If not we leave it alone? |
Member
Author
|
@niels9001 This PR only flips the default icon. It works because the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the default SettingsCard.ActionIcon chevron so it mirrors in RTL contexts, matching the Windows Settings behavior described in issue #846.
Changes:
- Sets a default
ActionIconinstance to aFontIconwithMirroredWhenRightToLeft=true. - Keeps the default glyph as
\uE974while enabling RTL-aware rendering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
66
to
72
| public SettingsCard() | ||
| { | ||
| this.DefaultStyleKey = typeof(SettingsCard); | ||
|
|
||
| // This is perhaps indicative of an issue with the action icon requiring a concrete FontElement instead of a template | ||
| ActionIcon = new FontIcon { Glyph = "\ue974", MirroredWhenRightToLeft = true }; | ||
| } |
Comment on lines
+69
to
+71
|
|
||
| // This is perhaps indicative of an issue with the action icon requiring a concrete FontElement instead of a template | ||
| ActionIcon = new FontIcon { Glyph = "\ue974", MirroredWhenRightToLeft = true }; |
| { | ||
| this.DefaultStyleKey = typeof(SettingsCard); | ||
|
|
||
| // This is perhaps indicative of an issue with the action icon requiring a concrete FontElement instead of a template |
| this.DefaultStyleKey = typeof(SettingsCard); | ||
|
|
||
| // This is perhaps indicative of an issue with the action icon requiring a concrete FontElement instead of a template | ||
| ActionIcon = new FontIcon { Glyph = "\ue974", MirroredWhenRightToLeft = true }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #846
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
The default
ActionIconis a chevron that points right, regardless of the FlowDirectionWhat is the new behavior?
The default
ActionIconis a chevron that points outwards, flipping based on the FlowDirectionPR Checklist
Please check if your PR fulfills the following requirements:
Other information
I'm not terribly happy with this solution. I think this poor solution represents an issue that the action icon maybe should be templated.