Skip to content

Remove SpriteVisual from visual tree in attached shadows before disposing of composition resources #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-hawker merged 4 commits into from
Feb 4, 2026
+7 −7
Merged

Remove SpriteVisual from visual tree in attached shadows before disposing of composition resources #818

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b452a4
Remove SpriteVisual from tree before disposing of resources
chris-blackman Jan 8, 2026
a1f220f
Merge branch 'main' into Ryken100/attached-shadow-fix-2
Arlodotexe Jan 10, 2026
db0587e
Merge branch 'main' into Ryken100/attached-shadow-fix-2
Arlodotexe Feb 2, 2026
f743974
Merge branch 'main' into Ryken100/attached-shadow-fix-2
Arlodotexe Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Extensions/src/Shadows/AttachedShadowBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ protected internal virtual void OnElementContextInitialized(AttachedShadowElemen
/// <param name="context">The <see cref="AttachedShadowElementContext"/> that is being uninitialized.</param>
protected internal virtual void OnElementContextUninitialized(AttachedShadowElementContext context)
{
context.ClearAndDisposeResources();
ElementCompositionPreview.SetElementChildVisual(context.Element, null!);
context.ClearAndDisposeResources();
}

/// <inheritdoc/>
Expand Down
12 changes: 6 additions & 6 deletions components/Extensions/src/Shadows/AttachedShadowElementContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ private void Uninitialize()

IsInitialized = false;

if (Element != null)
{
ElementCompositionPreview.SetElementChildVisual(Element, null!);
Element.SizeChanged -= OnElementSizeChanged;
}

Parent.OnElementContextUninitialized(this);

if (SpriteVisual != null)
Expand All @@ -148,12 +154,6 @@ private void Uninitialize()
Shadow.Dispose();
}

if (Element != null)
{
ElementCompositionPreview.SetElementChildVisual(Element, null!);
Element.SizeChanged -= OnElementSizeChanged;
}

SpriteVisual = null;
Shadow = null;
ElementVisual = null;
Expand Down
Loading