Feature: Add EnumOptionAttribute#228
Open
Poker-sang wants to merge 3 commits intoCommunityToolkit:mainfrom
Open
Feature: Add EnumOptionAttribute#228Poker-sang wants to merge 3 commits intoCommunityToolkit:mainfrom
Poker-sang wants to merge 3 commits intoCommunityToolkit:mainfrom
Conversation
a96163b to
381cb19
Compare
381cb19 to
57a4c34
Compare
Member
|
Good to see that new C# 12 features might make this a bit simpler to set up. However, we should be doing an evaluation of existing code before making refactors like this. We had custom logic for added flexibility, and this would need to be assessed and planned out before making improving. We'll keep the PR around for now, but let's get a ticket open to track our rationale and methodology. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use:
instead of
And generate accurate enum type for
ToolkitSampleEnumOption:All the changes are AOT compatiable