Find modules recursively by nelsonjr · Pull Request #362 · Comfy-Org/comfy-cli

nelsonjr · 2026-01-27T21:59:05Z

Implements a fix for issue #361 and also looks for models/ subdirectories. Example output:

┏━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Type          ┃ Model Name                                                ┃ Size        ┃
┡━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ diffusion     │ Wan2.2_Remix_NSFW_i2v_14b_high_lighting_v2.0.safetensors  │ 13956320 KB │
│ diffusion     │ Wan2.2_Remix_NSFW_i2v_14b_low_lighting_v2.0.safetensors   │ 13956320 KB │
│ diffusion     │ wan2.2_i2v_low_noise_14B_fp8_scaled.safetensors           │ 13959709 KB │
│ diffusion     │ wan2.2_i2v_high_noise_14B_fp8_scaled.safetensors          │ 13959709 KB │
│ loras         │ wan2.2_i2v_lightx2v_4steps_lora_v1_low_noise.safetensors  │ 1198220 KB  │
│ loras         │ wan2.2_i2v_lightx2v_4steps_lora_v1_high_noise.safetensors │ 1198220 KB  │
│ text_encoders │ umt5_xxl_fp8_e4m3fn_scaled.safetensors                    │ 6578034 KB  │
│ vae           │ wan_2.1_vae.safetensors                                   │ 247866 KB   │
└───────────────┴───────────────────────────────────────────────────────────┴─────────────┘

It also honors the folders when removing modules.

bigcat88

From quick look:

Can we use SUPPORTED_PT_EXTENSIONS variable?
If two subdirectories have files with the same name (e.g., vae/config.json and text_encoders/config.json), only one will be in the dict. When deleting by name, the wrong file could be deleted.
Minor thing: rglob() finds files at arbitrary depth, not just immediate children. This might find models in nested subdirs like text_encoders/subfolder/model.safetensors/

nelsonjr · 2026-02-03T19:44:34Z

From quick look:

Can we use SUPPORTED_PT_EXTENSIONS variable?

I will make the change. I did not notice the variable. Thanks.

If two subdirectories have files with the same name (e.g., vae/config.json and text_encoders/config.json), only one will be in the dict. When deleting by name, the wrong file could be deleted.

Thanks for the catch. Let me make sure that does not happen (and if that case happens, to offer them an option to pick which one to delete, or qualify the folder)

Minor thing: rglob() finds files at arbitrary depth, not just immediate children. This might find models in nested subdirs like text_encoders/subfolder/model.safetensors/

Good point. Given the risk of finding things not desired (and the reason I started this was to find the usual first-level children of models, where most things go), maybe a different (better?) approach would be to use a --max-levels variable to control how deep? (like find). We could default it to --max-depth=2 and user can change to any number.

nelsonjr · 2026-02-03T22:44:39Z

I updated the delete to take into consideration multiple matching names:

(venv) root@comfy-playground:~/cli# comfy model list
┏━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Type           ┃ Model Name         ┃ Size     ┃
┡━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ checkpoints    │ model1.safetensors │ 10240 KB │
│ loras          │ model1.safetensors │ 5120 KB  │
│ text_encoders  │ model1.safetensors │ 128 KB   │
│ upscale_models │ upme.pth           │ 2048 KB  │
│ vae            │ model1.safetensors │ 1024 KB  │
└────────────────┴────────────────────┴──────────┘

If picking from the menu:

(venv) root@comfy-playground:~/cli# comfy model remove
? Select models to delete: [model1.safetensors]
These models will be deleted:
  - /root/comfy/ComfyUI/models/checkpoints/model1.safetensors
  - /root/comfy/ComfyUI/models/loras/model1.safetensors
  - /root/comfy/ComfyUI/models/text_encoders/model1.safetensors
  - /root/comfy/ComfyUI/models/vae/model1.safetensors
Are you sure you want to delete the selected files? [y/N]: y
Deleted: /root/comfy/ComfyUI/models/checkpoints/model1.safetensors
Deleted: /root/comfy/ComfyUI/models/loras/model1.safetensors
Deleted: /root/comfy/ComfyUI/models/text_encoders/model1.safetensors
Deleted: /root/comfy/ComfyUI/models/vae/model1.safetensors

Or specifying in the command line:

# comfy model remove --model-names model1.safetensors
These models will be deleted:
  - /root/comfy/ComfyUI/models/checkpoints/model1.safetensors
  - /root/comfy/ComfyUI/models/loras/model1.safetensors
  - /root/comfy/ComfyUI/models/text_encoders/model1.safetensors
  - /root/comfy/ComfyUI/models/vae/model1.safetensors
Are you sure you want to delete the selected files? [y/N]: _

In case of multiple matches, you can specify which one more specifically:

# comfy model remove --model-names loras/model1.safetensors
These models will be deleted:
  - /root/comfy/ComfyUI/models/loras/model1.safetensors
Are you sure you want to delete the selected files? [y/N]: _

nelsonjr · 2026-02-04T00:32:51Z

Implemented --max-depth to control how deep the scan will go:

Default: --max-depth=2 to cover models/ and models/????/ only:

# comfy model list 
┏━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Type           ┃ Model Name         ┃ Size     ┃
┡━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ checkpoints    │ model1.safetensors │ 10240 KB │
│ loras          │ model1.safetensors │ 5120 KB  │
│ text_encoders  │ model1.safetensors │ 128 KB   │
│ upscale_models │ upme.pth           │ 2048 KB  │
│ vae            │ model1.safetensors │ 1024 KB  │
│ <models>       │ local.safetensors  │ 50 KB    │
└────────────────┴────────────────────┴──────────┘

Restricting further:

# comfy model list --max-depth=1
┏━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━┓
┃ Type     ┃ Model Name        ┃ Size  ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━┩
│ <models> │ local.safetensors │ 50 KB │
└──────────┴───────────────────┴───────┘

nelsonjr · 2026-02-04T00:42:00Z

From quick look:

Can we use SUPPORTED_PT_EXTENSIONS variable?

I will make the change. I did not notice the variable. Thanks.

If two subdirectories have files with the same name (e.g., vae/config.json and text_encoders/config.json), only one will be in the dict. When deleting by name, the wrong file could be deleted.

Thanks for the catch. Let me make sure that does not happen (and if that case happens, to offer them an option to pick which one to delete, or qualify the folder)

Minor thing: rglob() finds files at arbitrary depth, not just immediate children. This might find models in nested subdirs like text_encoders/subfolder/model.safetensors/

Good point. Given the risk of finding things not desired (and the reason I started this was to find the usual first-level children of models, where most things go), maybe a different (better?) approach would be to use a --max-levels variable to control how deep? (like find). We could default it to --max-depth=2 and user can change to any number.

Hi @bigcat88, I updated the code to address your feedback. PTAL at your convenience. Examples of the code in action as comments above.

bigcat88

Having some tests for this will be good. At minimum we should test:

Flat files in root
Files in subdirectories
max_depth behavior
Filtering by SUPPORTED_PT_EXTENSIONS

bigcat88 · 2026-02-05T14:16:28Z

comfy_cli/command/models/models.py

+    """List all models in the specified directory and its subdirectories.
+
+    Returns a list of tuples (model_type, file_path) where model_type is the
+    subdirectory name with '_models' suffix stripped if present.


Can you explain where the strip of "models" prefix occurs?

bigcat88 · 2026-02-05T14:19:13Z

comfy_cli/command/models/models.py

+    if not path.exists():
+        return models
+    if max_depth == 0:
+        print("max_depth must be 1 or greather")


This just prints a message and returns empty, causing the caller to show "No models found" - which is a little bit misleading.
This should be a typer.BadParameter or a min=1 constraint on the typer Option.

bigcat88 · 2026-02-05T14:19:56Z

README.md

 - Model remove

-  `comfy model remove ?[--relative-path <PATH>] --model-names <model names>`
+  `comfy model remove ?[--relative-path <PATH>] ?[--max-depth <LEVELS] --model-names <model names>`


typo: missing >

bigcat88 · 2026-02-05T14:20:30Z

comfy_cli/command/models/models.py

+
+    # Print a list of models to delete:
+    if to_delete:
+        print("These models will be deleted:")


Can we use typer.echo instead of print ?

bigcat88 · 2026-02-05T14:23:09Z

comfy_cli/command/models/models.py


+    # Build a mapping from display name to path for selection
+    sorted_models = sorted(available_models, key=lambda x: x[1].name)
+    #model_path_by_name = {model.name: model for _model_type, model in available_models}


please, remove the line with commented code

bigcat88 · 2026-02-05T14:25:47Z

comfy_cli/command/models/models.py

    # Scenario #2: User did not provide model names, prompt for selection
    else:
-        selections = ui.prompt_multi_select("Select models to delete:", [model.name for model in available_models])
+        selections = ui.prompt_multi_select("Select models to delete:", list(model_path_by_name.keys()))


Did you try this code when model1.safetensors file exists in two different sub-directories?
Does the interactive usage displays correct prompt which one will be deleted?

Find modules recursively

44ddff9

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 27, 2026

nelsonjr mentioned this pull request Jan 27, 2026

comfy model list does not find models in subdirectories of /models Comfy-Org/ComfyUI#12123

Closed

1 task

bigcat88 reviewed Feb 3, 2026

View reviewed changes

Disambiguate models with the same name

18372dd

implement max_depth

3facd83

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 4, 2026

nelsonjr added 2 commits February 4, 2026 00:35

Catch missing module with path to display to the user

c1acbed

add documentation

f97f748

bigcat88 reviewed Feb 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Find modules recursively#362

Find modules recursively#362
nelsonjr wants to merge 5 commits intoComfy-Org:mainfrom
nelsonjr:fix-issue-361

nelsonjr commented Jan 27, 2026

Uh oh!

bigcat88 left a comment

Uh oh!

nelsonjr commented Feb 3, 2026

Uh oh!

nelsonjr commented Feb 3, 2026

Uh oh!

nelsonjr commented Feb 4, 2026

Uh oh!

nelsonjr commented Feb 4, 2026 •

edited

Loading

Uh oh!

bigcat88 left a comment

Uh oh!

bigcat88 Feb 5, 2026

Uh oh!

bigcat88 Feb 5, 2026

Uh oh!

bigcat88 Feb 5, 2026

Uh oh!

bigcat88 Feb 5, 2026

Uh oh!

bigcat88 Feb 5, 2026

Uh oh!

bigcat88 Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nelsonjr commented Jan 27, 2026

Uh oh!

bigcat88 left a comment

Choose a reason for hiding this comment

Uh oh!

nelsonjr commented Feb 3, 2026

Uh oh!

nelsonjr commented Feb 3, 2026

Uh oh!

nelsonjr commented Feb 4, 2026

Uh oh!

nelsonjr commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bigcat88 left a comment

Choose a reason for hiding this comment

Uh oh!

bigcat88 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

bigcat88 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

bigcat88 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

bigcat88 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

bigcat88 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

bigcat88 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nelsonjr commented Feb 4, 2026 •

edited

Loading