Expose unselectCell on DataGrid handle#3927
Open
marcellofuschi wants to merge 1 commit intoComcast:mainfrom
Open
Expose unselectCell on DataGrid handle#3927marcellofuschi wants to merge 1 commit intoComcast:mainfrom
marcellofuschi wants to merge 1 commit intoComcast:mainfrom
Conversation
0d13a12 to
0135d78
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3927 +/- ##
==========================================
- Coverage 97.34% 97.09% -0.25%
==========================================
Files 36 36
Lines 1169 1172 +3
Branches 345 345
==========================================
Hits 1138 1138
- Misses 31 34 +3
🚀 New features to boost your workflow:
|
Collaborator
|
The selection outline persists even when the cell is not focused. We can do the following to show the outline only on focused cells? Does that work for you or the intention is to actually clear the selected position? https://github.com/Comcast/react-data-grid/blob/main/src/style/cell.ts#L25 |
Author
|
The intention is to clear the selected position because we base some other UI behavior on the selected cell, and when not focused we'd like to avoid triggering that behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with
DataGridI found myself needing to unselect the selected cell (when the user moves focus to an external element)