Open
Conversation
infinitis
force-pushed
the
cldr_compilation_fix
branch
from
6f1bf0a to
d3bf1e4
Compare
smt116
approved these changes
Nov 11, 2025
smt116
left a comment
smt116
left a comment
There was a problem hiding this comment.
This might be okay, but what is the reason here?
Author
|
It was failing to compile after upgrading coinbits: https://github.com/CoinbitsInc/coinbits/actions/runs/19162559654/job/54776103051?pr=5466 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code causes an error when compiling Coinbits with elixir-1.19.2-otp-28. Looks like we only use this cldr code in tests so looked to me like the easiest fix was to add an extra guard.