London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests by HM-127BTY · Pull Request #1670 · CodeYourFuture/Module-Structuring-and-Testing-Data

HM-127BTY · 2026-10-09T19:06:05Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1059.

Changelist

I built code while writing tests for the code using node and jest to test.

added in code for checks for J Q K and A

valid single digit card Arbitrary non-card string Incorrect suit

Copied test code for other angles.

Added in test for Basic proper fraction: Numerator < Denominator

Added code for Number cards 2-10

fixed error on numbered cards.

…g () => in my thrown error tests

hackertainment

Thank you for your coursework. Just need to design test cases that should be enough to cover different combination of values. Please keep it up.

hackertainment · 2026-10-09T20:15:05Z

+    return "Straight angle";
+  } else if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  } else if (angle <= 0 || angle >= 360) {


This is correct but can be just using else to include the rest of the values.

hackertainment · 2026-10-09T20:16:09Z

+// - "Invalid angle" for angles outside the valid range.
+test("Classifies Invalid angles", () => {
+  const right = getAngleType(360);
+  assert.equal(right, "Invalid angle");
+});


There should be one more boundary case for invalid angle. Can you think of it? Please add it back. Thank you.

hackertainment · 2026-10-09T20:17:18Z

+test(`should return "Invalid angle" when (0 > angle > 360)`, () => {
+  expect(getAngleType(361)).toEqual("Invalid angle");
+  expect(getAngleType(396)).toEqual("Invalid angle");
+  expect(getAngleType(-57)).toEqual("Invalid angle");
+});


There should be two boundary cases in this test suite. Can you think of them? Please add them. Thank you.

hackertainment · 2026-10-09T20:19:56Z

+test("Improper fraction: Denominator = 0", () => {
+  assert.equal(isProperFraction(1, 0), false);
+});
+
+test("Proper fraction with negative number: -Numerator < Denominator", () => {
+  assert.equal(isProperFraction(-1, 2), true);
+});
+
+test("Improper fraction with negative number: -Numerator > Denominator", () => {
+  assert.equal(isProperFraction(-2, 1), false);
+});


There should be 3 more test suites related to either zero or negative values. Can you think of them? Please add them back. Thank you.

hackertainment · 2026-10-09T20:21:37Z

+// Special case: Proper fraction with negative number: -Numerator < Denominator
+test(`should return true when: -Numerator < Denominator`, () => {
+  expect(isProperFraction(-1, 2)).toEqual(true);
+  expect(isProperFraction(-6, 8)).toEqual(true);
+  expect(isProperFraction(-10, 20)).toEqual(true);
+});
+
+// Special case: Improper fraction with negative number: -Numerator > Denominator
+test(`should return false when: -Numerator > Denominator`, () => {
+  expect(isProperFraction(-2, 1)).toEqual(false);
+  expect(isProperFraction(-5, 4)).toEqual(false);
+  expect(isProperFraction(-20, 10)).toEqual(false);
+});


There should be two more negative test suites and two zero related test suites. Please add them back. Thank you.

hackertainment · 2026-10-09T20:24:10Z

+  let suit = card.slice(-1);
+  let cardNumber = card.slice(0, -1);
+  let value = Number(cardNumber);
+
+  if (card.length >= 4) {


Since card.slice() is done before checking card.length, the slice may not work for some lengths. Please fix this issue. Thank you.

hackertainment · 2026-10-09T20:25:28Z

+    return 11;
+  } else if (value >= 2 && value <= 10) {
+    return value;
+  } else if (Value > 10) {


have you tested it? I don't think it is correct. Please fix this bug. Thank you.

hackertainment · 2026-10-09T20:26:58Z

Both valid and invalid cards, there should be more test cases covering various combinations. Please add them. Thank you.

hackertainment · 2026-10-09T20:28:27Z

+//   Invalid Cards
+test(`Should throw error 'expected a number followed by a suit, but got "invalid"' with invalid card`, () => {
+  expect(() => getCardValue("120♥")).toThrow;
+  new Error('expected a number followed by a suit, but got "invalid"');
+  expect(() => getCardValue("203♦")).toThrow;
+  new Error('expected a number followed by a suit, but got "invalid"');
+});
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror

+test(`Should throw error "Incorrect suit given" when given wrong symbol"`, () => {
+  expect(() => getCardValue("2☺")).toThrow;
+  new Error("Incorrect suit given");
+});
+
+test(`Should throw error "Incorrect card number given" when given wrong 2 digit number"`, () => {
+  expect(() => getCardValue("25♠")).toThrow;
+  new Error("Incorrect card given");
+});


There should be more test cases for invalid cards. Please add them. Thank you.

HM-127BTY added 30 commits October 7, 2026 18:07

Work on "Right angle"

e8606f9

Added tests for all the angles, next working on code

53621cd

Added code for Acute angle

5721c8b

Added code for Obtuse angle

5e692d8

Added code for Straight angle

b61b4b4

Added code for Reflex angles

7ccf911

Added code for Invalid angle

426aabb

fixed errors and rearranged code to be easier to read

1c3277f

Set up testing requirements for the fractions

c4786d8

Done the code for fractions coving test requests.

707ac48

cleaned up the code

16f4f20

added basic tests needed and non - card string.

e3a8f17

added in code for checks for J Q K and A

working on code and trying to fix errors

ae7ef77

finished code and tests for 3 types:

d4db679

valid single digit card Arbitrary non-card string Incorrect suit

cleaned up errors i encountered .

9970ef6

Added in test for Right angle.

2830bf3

Copied test code for other angles.

Added test for Obtuse angles

c7af1dd

Added test for Straight angles

2fc4cd2

Added tests for Right angles

8662c14

Added tests for Invalid angles

6ae03b0

Added in commented tests to update as I progress though tests.

3727932

Added in test for Basic proper fraction: Numerator < Denominator

Added code for Improper fraction: Numerator = Denominator

5d6c6ef

Added code for Improper fraction: Numerator > Denominator

b155253

Added code for -Numerator > Denominator

6f64f2e

Setup code for more tests.

b37a765

Added code for Number cards 2-10

Added code for return 10 for J, Q, K.

9770764

fixed error on numbered cards.

Added code for throw error invalid card

67f4dd7

Added in testing code for Incorrect Suit and fixed errors with lackin…

77cf05b

…g () => in my thrown error tests

fixing erros in code and including "Incorrect card number" test

3f42554

fixed errors and put in more test code for Incorrect card given

328f3c1

HM-127BTY added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 9, 2026

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 9, 2026

hackertainment reviewed Oct 9, 2026

View reviewed changes

hackertainment mentioned this pull request Oct 9, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 9, 2026

Navigation Menu

Repository navigation

London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests - #1670

London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests#1670
HM-127BTY wants to merge 30 commits into
CodeYourFuture:mainfrom
HM-127BTY:coursework/sprint-2-implement-and-rewrite

HM-127BTY commented Oct 9, 2026

Uh oh!

hackertainment left a comment

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HM-127BTY commented Oct 9, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants