Repository navigation
London | 26-ITP-Sep | Ebrahim Moqbel | Sprint 1 | Refactoring-Dead-Code CYF-1066 - #1669
Open
Ebrahim-Moqbel wants to merge 2 commits into
Open
Ebrahim-Moqbel wants to merge 2 commits into
Ebrahim-Moqbel wants to merge 2 commits into
Conversation
Ebrahim-Moqbel
added
the
Needs Review
hackertainment
added
Review in progress
Comment on lines
-15
to
+13
| const greetingMessage = sayHello(greeting, testName); | ||
|
|
||
| console.log(greetingMessage); // 'hello, Aman!' | ||
| console.log(sayHello(greeting, testName)); // 'hello, Aman!' |
There was a problem hiding this comment.
While using one line may look better in this case, there is nothing wrong with the original code using two lines. In some cases with larger code base, having a variable to store the return value may even be a better choice sometimes.
|
Thank you for your coursework. You have completed this PR successfully. Keep it up :-) |
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
refactored the dead code