Manchester | Precious Moses | 26-ITP-Sep | Sprint 2 | Practice-TDD by moses77-boop · Pull Request #1666 · CodeYourFuture/Module-Structuring-and-Testing-Data

moses77-boop · 2026-10-09T04:58:56Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1060

Changelist

This PR contains Test-Development Driven (TDD) concepts.

… and period handling

…arity

…urate time formatting

…ases

…ncies

…mber function

… 12 and 13

…alNumber function

…revent negative values

…and ensure negative count check is performed at the start

… of count of 0

…tr function

hackertainment

Generally good work. Just aware not to commit package.json and package-lock.json into the repo next time. If you don't know how to choose specific file to stage before commit, please ask a volunteer on Saturday class. Thank you.

hackertainment · 2026-10-09T20:34:15Z

+  const getlastDigit = num % 10;
+  const getlastTwoDigit = num % 100;


Usually we will just use verb for function names, so a better variable names would be lastDigit and lastTwoDigit respectively.

hackertainment · 2026-10-09T20:41:27Z

Your test cases are correct. Just for you to think a little bit more, besides const str = "hello", what special string should also be added to each of the test cases?

Thanks for the feedback!
I have refactored my code to include special string case.

… string

hackertainment · 2026-10-10T21:18:38Z

Congratulation, you have completed this PR successfully.

moses77-boop added 30 commits October 3, 2026 10:16

refactor: update formatAs12HourClock function to improve time parsing…

c3cc796

… and period handling

refactor: update test syntax to use arrow functions for consistency

b03e0fb

fix: ensure formatAs12HourClock function exports correctly

05e8ef3

test: add test case for converting midnight time

1544b38

refactor: improve time conversion logic and enhance test cases for cl…

8230a0e

…arity

fix: correct return statement in formatAs12HourClock function for acc…

ead95df

…urate time formatting

test: add test case for converting the last minute before noon

19e10f5

test: add test case for converting exact noon to pm

15938a2

test: add test case for converting time just after noon

8acdeaa

fix: add missing newline at end of timeConverter.test.js

a7d1115

fix: remove space before am/pm in time formatting and clean up test c…

ee8f85b

…ases

fix: remove space before period in time formatting

f93cd35

test: add test case for converting late evening hour

59863c5

test: add test case for converting last minute of the day

c6ed571

fix: correct expected output for first afternoon hour test case

ced1c53

test: add test case for preserving minutes with leading zero

9f0876f

test: update console log to test formatting for 8:00 AM

03c860b

test: add test case for preserving non-zero minutes

42d563c

test: update console log to test formatting for 8:40 AM

91ccb0c

Remove commented-out code from time formatting function

472364d

Remove console log from time formatting function

5b48a96

Add jsconfig.json for TypeScript configuration

8a74015

Format code and improve readability

27919c8

Simplify period determination and improve formatting

fa688b1

Refactor display hour calculation for 12-hour clock format

5d58269

Remove jsconfig.json and clean up package.json by deleting devDepende…

f9fac2a

…ncies

Refactor folders to match main

aba0771

Add test case for classifying acute angles

dc99174

Add test case for classifying acute angles at 1 degree

ca9a48e

Add test case for classifying acute angles at 89 degrees

e9127dd

moses77-boop added 14 commits October 9, 2026 04:23

Fix getOrdinalNumber function to correctly handle numbers ending with 2

e6d3f80

Add test cases for numbers ending with 3 in getOrdinalNumber function

ca98356

Fix getOrdinalNumber function to correctly handle numbers ending with 3

e430ece

Add test cases for numbers ending with 11, 12, and 13 in getOrdinalNu…

4abd0e7

…mber function

Fix getOrdinalNumber function to correctly handle numbers ending with…

5f7b139

… 12 and 13

Add test cases for numbers ending with 4, 10, 20, and 100 in getOrdin…

75a8087

…alNumber function

Refactor repeatStr function to accept parameters for string and count

9717056

Refactor repeatStr function to correctly handle count parameter and p…

677819c

…revent negative values

Add test case for repeating string 1 time

d5bb21a

Refactor repeatStr function to remove redundant string concatenation …

99c6335

…and ensure negative count check is performed at the start

Fix test case for repeating string 1 time and ensure correct handling…

b780757

… of count of 0

Add test case to ensure error is thrown for negative count in repeatS…

64be7a7

…tr function

Fix syntax error in test cases by adding missing closing braces

41a3faa

Revert unrelated implement-and-rewrite-tests changes

56fa378

moses77-boop added 🦑 Size Large 4-8 hours 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 9, 2026

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 9, 2026

hackertainment reviewed Oct 9, 2026

View reviewed changes

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 9, 2026

hackertainment mentioned this pull request Oct 9, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

moses77-boop added 4 commits October 9, 2026 22:19

Fix variable naming for clarity in getOrdinalNumber function

9370f27

Add test case for handling empty string in repeatStr function

389c799

Add test case to ensure error is thrown for negative count with empty…

639dda6

… string

Add test case for repeating a string of symbols in repeatStr function

4a915c3

hackertainment added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 10, 2026

Navigation Menu

Repository navigation

Manchester | Precious Moses | 26-ITP-Sep | Sprint 2 | Practice-TDD - #1666

Manchester | Precious Moses | 26-ITP-Sep | Sprint 2 | Practice-TDD#1666
moses77-boop wants to merge 132 commits into
CodeYourFuture:mainfrom
moses77-boop:coursework/sprint-3-practice-tdd

moses77-boop commented Oct 9, 2026

Uh oh!

hackertainment left a comment

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

hackertainment Oct 9, 2026

Uh oh!

moses77-boop Oct 9, 2026

Uh oh!

hackertainment commented Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const getlastDigit = num % 10;
		const getlastTwoDigit = num % 100;

Conversation

moses77-boop commented Oct 9, 2026

Task code

Changelist

Uh oh!

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

moses77-boop Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants