Repository navigation
Manchester | 26-ITP-Sep | Precious Moses | Sprint 2 | Implement and Rewrite Tests - #1665
Open
moses77-boop wants to merge 104 commits into
Open
moses77-boop wants to merge 104 commits into
moses77-boop wants to merge 104 commits into
Conversation
… and period handling
…urate time formatting
…ithub.com/moses77-boop/Module-Structuring-and-Testing-Data into coursework/sprint-3-implement-and-rewrite
…d-rewrite' into coursework/sprint-3-implement-and-rewrite
…d-rewrite' into coursework/sprint-3-implement-and-rewrite
…ithub.com/moses77-boop/Module-Structuring-and-Testing-Data into coursework/sprint-3-implement-and-rewrite
…d-rewrite' into coursework/sprint-3-implement-and-rewrite
moses77-boop
added
📅 Sprint 2
hackertainment
added
Review in progress
There was a problem hiding this comment.
Almost there, how about numerator is 0 and denominator is negative? is it proper or improper? Please add it to the test case as well. Thank you.
Author
There was a problem hiding this comment.
Thanks for the feedback!
I've refactored my code.
|
Good work. Just need to fix #1665 (comment) . Keep it up. |
hackertainment
added
Reviewed
|
Congratulation, you have completed this PR successfully. |
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1059
Changelist
This PR contains test implementation and function re-usability.