Repository navigation
Cape Town | 26-ITP-Sept | Edward Kganyago | Sprint 2 | Time Converter - #1664
Open
edwardkganyago45-source wants to merge 2 commits into
Open
edwardkganyago45-source wants to merge 2 commits into
edwardkganyago45-source wants to merge 2 commits into
Conversation
edwardkganyago45-source
added
📅 Sprint 2
cjyuan
reviewed
Oct 9, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Test cases are good.
Note: I think this exercise is Sprint 1.
Comment on lines
+2
to
+4
| const [hoursStr, minutesStr] = time.split(":"); | ||
| const hours = Number(hoursStr); | ||
| const minutes = minutesStr ?? "00"; |
Contributor
There was a problem hiding this comment.
Could you walk me through how minutesStr ?? "00" is evaluated?
You probably overlooked how ?? works.
There was a problem hiding this comment.
The first expression preserves the empty string; the second replaces it
Contributor
There was a problem hiding this comment.
How could minutesStr be an empty string? How is the code on line 4 different from
const minutes = minutesStr;
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1197
Changelist
fixed the time converter and tested edge cases