Repository navigation
Conversation
codebyra
added
the
Needs Review
Luro91
reviewed
Oct 8, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works correctly and the tests cover the edge cases
| export {formatAs12HourClock}; | ||
| const formattedHours = String(hours12).padStart(2, "0"); | ||
|
|
||
| return `${formattedHours}${minutes} ${period}`; |
There was a problem hiding this comment.
Nice use of helper variables. This makes this line easy to read and understand (because the calculations and formatting is happening before)
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1197
Changelist
Fixed bugs in the
formatAs12HourClockfunction to correctly handle midnight, noon, AM/PM conversions, and minutes. Added 16 tests covering various edge cases, all passing successfully.