Repository navigation
Simulation | Remove grading notes from the scenario and the report - #37
Merged
Merged
Conversation
A rubric sidecar or scenario field could be read alongside the exercise. Reports are transcripts only, and leftover grading fields are dropped before the client or agents see the config. Co-authored-by: Cursor <cursoragent@cursor.com>
BrianGenisio
marked this pull request as ready for review
October 7, 2026 20:05
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (19)
💤 Files with no reviewable changes (10)
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe project removes rubric fields from scenario configuration and client responses. The transcript extraction command no longer accepts or loads rubric files or includes rubric sections in reports. Rubric helper code, tests, example rubric files, and related setup instructions were removed or updated. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to No concrete merge-blocking risk is established for the rubric-removal change. The listed test outcomes remain unreported; complete the usual checks before merging. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The simulation no longer reads a grading rubric. Session reports are transcripts only, so grading notes stay out of Cosmo, the characters, and the learner UI.
Changes
Grading used to ride along in two places: a
rubric.jsonsidecar thatnpm run reportpasted into the transcript, andrubricHintson the scenario. Both are gone, including the example sidecar files.If a scenario file still has
rubricorrubricHints, load drops those fields and records a warning./api/configstrips them again before the client sees the config. Agent input is unchanged: the mailbox, the character card, andsystemPromptExtra.Worth a close look in
lib/scenario.js(the drop and the warning) andextract-conversations.js(report mode no longer accepts--rubric).Test plan
npm testnpm run reportagainst a session and confirm the markdown has no Rubric hints sectionrubricHintsto a throwaway scenario, start the server, and confirm the log says the field is ignored andGET /api/configomits it