fix(api): resolve samlify's SamlLib under Node's ESM loader - #183
Merged
Merged
Conversation
samlify is CommonJS and re-exports SamlLib through a getter that cjs-module-lexer does not detect, so `import * as samlify` leaves it undefined in the compiled build and every signed-in SSO attempt 500'd with "Cannot read properties of undefined (reading 'replaceTagsByValue')". vitest's interop exposes it as a named export, which is why the suite never saw it. Take module.exports (the `default` view) when it carries SamlLib. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first signed-in Slack SSO attempt against the live site returned
500 internal_error(traceId01a0b302-abe6-7f55-9ebd-32140e782e80):samlify is CommonJS. Under Node's ESM loader
cjs-module-lexerdoes not detectSamlLib(re-exported through a getter), soimport * as samlifyleaves itundefined; onlydefault(module.exports) carries it. vitest's interop exposes it as a named export, which is why all 19 SAML tests pass while production fails. Reproduced with plainnode --input-type=module -e "import * as s from 'samlify'; …".Fix: resolve from whichever view carries
SamlLib. Verified by building and importingdist/saml/config.jsunder plain Node. Plan:plans/samlify-esm-interop.md(follow-up noted: a compiled-output smoke test in CI).🤖 Generated with Claude Code
https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ