Fix data loss on cancelled io#55
Merged
Merged
Conversation
vadimskipin
reviewed
May 29, 2026
vadimskipin
reviewed
May 29, 2026
Collaborator
vadimskipin
left a comment
There was a problem hiding this comment.
As I understand this is a cancel/completion race. Yes, we must not clear result pointer and let kernel to resolve the outcome.
Collaborator
|
I am not an experienced github user - can you squash commits before merging? |
c47f008 to
b6287fc
Compare
vadimskipin
reviewed
May 29, 2026
vadimskipin
previously approved these changes
May 30, 2026
b6287fc to
be57e23
Compare
vadimskipin
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of a potential data loss:
FiberScheduler::readto read from the fd.future->cancel().future->result = nullptr.It's enough to just remove
future->result = nullptrfromFiberScheduler::cancelIo. And it doesn't seem like that will break any invariant.To add a deterministic red-green test, the simplest solution I found is to inject a hook on a future which runs after reading CQE from the ring and before processing it. This code is only compiled for test builds (i.e. debug or sanitizer). Might be potentially useful for other similar tests as well.