Added TransportException and tests for it#2889
Open
chernser wants to merge 1 commit into
Open
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
There was a problem hiding this comment.
Pull request overview
Adds a new TransportException in client-v2 to better classify transport-layer failures (currently used for SSL-related issues) and extends integration tests to validate the new exception type.
Changes:
- Introduced
TransportExceptionas a dedicated exception type for transport-layer failures. - Updated HTTP client exception wrapping to throw
TransportExceptionforSSLException. - Added an integration test to assert
TransportExceptionis raised for SSL failures; added aClientExceptionctor that acceptsqueryId.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| client-v2/src/test/java/com/clickhouse/client/ErrorHandlingTests.java | Adds an integration test validating TransportException behavior for SSL failures. |
| client-v2/src/main/java/com/clickhouse/client/api/TransportException.java | New public exception type intended for transport-layer failures. |
| client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java | Wraps SSLException as TransportException instead of generic ClickHouseException. |
| client-v2/src/main/java/com/clickhouse/client/api/ClientException.java | Adds a constructor overload carrying queryId. |
Comment on lines
+3
to
+7
| /** | ||
| * Any exception that happens inside transport logic and hard to categorize as client logic | ||
| * like connection initiation or data transfer. These exceptions are not retriable normally. | ||
| * Main purpose of this exception is to wrap transport specific. | ||
| */ |
Comment on lines
900
to
902
| if (cause instanceof SSLException) { | ||
| return new ClickHouseException("SSL Problem", cause, queryId); | ||
| return new TransportException("SSL Problem", cause, queryId); | ||
| } |
Comment on lines
+87
to
+97
| try (Client client = new Client.Builder() | ||
| .addEndpoint("https://localhost:" + secureServer.getPort()) | ||
| .setUsername("default") | ||
| .setPassword(ClickHouseServerForTest.getPassword()) | ||
| .compressClientRequest(true) | ||
| .build()) { | ||
|
|
||
| TransportException tex = Assert.expectThrows(TransportException.class, | ||
| () -> client.query("SELECT 1").get()); | ||
| Assert.assertTrue(tex.getMessage().contains("SSL Problem")); | ||
| } |
mshustov
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: