style: use parentheses for Less mixin invocation across all .less files#873
Open
style: use parentheses for Less mixin invocation across all .less files#873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clever Coding Standards Agreement
Jira:
https://clever.atlassian.net/browse/DD-7212
Overview:
Less 4.x deprecates the old bare mixin invocation syntax (
.myMixin;) in favor of the explicit call syntax with parentheses (.myMixin();). This PR updates every.lessfile in the repo — both source components undersrc/and documentation examples underdocs/— to use the parenthesized call form. ThegenBorderRadius.jscode-generation script is also updated so that future runs of the generator emit the correct syntax.Changes included:
src/**/*.less: All mixin calls in component styles updated to use()syntaxdocs/**/*.less: All mixin calls in documentation example styles updated to use()syntaxsrc/less/border_radius.less: Composite border-radius mixin calls updatedgenBorderRadius.js: Generator script updated to emit()syntax for future regenerationsRelated PRs:
https://github.com/Clever/sd2/pull/10388
https://github.com/Clever/clever-ui/pull/285
Screenshots/GIFs:
No visual changes expected — this is a pure syntax update with identical compiled output.
Testing:
Roll Out:
package.jsonnpm version minornpm version majornpm version minorComponentsView.jsx. To do so:docs/assets/imgwith the format<COMPONENT URL LINK>.pngmake deploy-docs)