Skip to content

feat(msgpool): update max untrusted actor pending message limit#7127

Merged
hanabi1224 merged 2 commits into
mainfrom
akaladarshi/untrusted-pending-msg-limit
Jun 1, 2026
Merged

feat(msgpool): update max untrusted actor pending message limit#7127
hanabi1224 merged 2 commits into
mainfrom
akaladarshi/untrusted-pending-msg-limit

Conversation

@akaladarshi
Copy link
Copy Markdown
Collaborator

@akaladarshi akaladarshi commented Jun 1, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Increased per-sender limit for pending messages accepted via the untrusted mempool path from 10 to 100 to expand message pool capacity.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ce3014e7-9072-4e07-82d5-475b19e13e0a

📥 Commits

Reviewing files that changed from the base of the PR and between 0f85eec and 7f964d7.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/message_pool/msgpool/msg_pool.rs

Walkthrough

This PR increases the per-sender limit for messages accepted via the untrusted mempool path from 10 to 100 by updating a module-private constant in the message pool implementation and documenting the change in the changelog.

Changes

Untrusted mempool per-sender limit increase

Layer / File(s) Summary
Per-sender limit constant update and changelog
src/message_pool/msgpool/msg_pool.rs, CHANGELOG.md
MAX_UNTRUSTED_ACTOR_PENDING_MESSAGES is increased from 10 to 100, allowing a higher capacity for untrusted senders in the message pool. The change is documented in the changelog.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • hanabi1224
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: updating the max untrusted actor pending message limit from 10 to 100.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch akaladarshi/untrusted-pending-msg-limit
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch akaladarshi/untrusted-pending-msg-limit

Comment @coderabbitai help to get the list of available commands and usage tips.

@akaladarshi akaladarshi marked this pull request as ready for review June 1, 2026 15:47
@akaladarshi akaladarshi requested a review from a team as a code owner June 1, 2026 15:47
@akaladarshi akaladarshi requested review from hanabi1224 and sudo-shashank and removed request for a team June 1, 2026 15:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.39%. Comparing base (0f85eec) to head (7f964d7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/message_pool/msgpool/msg_pool.rs 87.75% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f85eec...7f964d7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hanabi1224 hanabi1224 added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit e5c6427 Jun 1, 2026
45 of 48 checks passed
@hanabi1224 hanabi1224 deleted the akaladarshi/untrusted-pending-msg-limit branch June 1, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants