Skip to content

ci: stop installing the removed Android SDK "tools" package - #660

Merged
BrawlerXull merged 1 commit into
CCExtractor:mainfrom
BrawlerXull:fix/ci-setup-android-tools
Oct 1, 2026
Merged

BrawlerXull merged 1 commit into
CCExtractor:mainfrom
BrawlerXull:fix/ci-setup-android-tools

Conversation

@BrawlerXull

@BrawlerXull BrawlerXull commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

android-actions/setup-android@v3 installs "tools platform-tools" by default. Google removed the legacy "tools" package from its SDK repository between 2026-09-14 and 2026-09-15, so sdkmanager now exits with "Failed to find package 'tools'" and every workflow that uses the setup-rust-android composite action fails before Flutter runs (Flutter CI, Nightly Build & Log, Nightly F-Droid).

The runner image and cmdline-tools version were identical in the last passing and first failing nightly runs; only the remote repository changed. Install platform-tools only; cmdline-tools already replaces the old SDK Tools.

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #(issue_no)

Replace issue_no with the issue number which is fixed in this PR

Screenshots

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

Summary by CodeRabbit

  • Chores
    • Updated Android build setup to request platform tools explicitly and use the runner’s existing command-line tools.

android-actions/setup-android@v3 installs "tools platform-tools" by
default. Google removed the legacy "tools" package from its SDK
repository between 2026-09-14 and 2026-09-15, so sdkmanager now exits
with "Failed to find package 'tools'" and every workflow that uses the
setup-rust-android composite action fails before Flutter runs (Flutter
CI, Nightly Build & Log, Nightly F-Droid).

The runner image and cmdline-tools version were identical in the last
passing and first failing nightly runs; only the remote repository
changed. Install platform-tools only; cmdline-tools already replaces
the old SDK Tools.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 979e850c-291e-4306-964f-b8d3cbe78fdf

📥 Commits

Reviewing files that changed from the base of the PR and between 87e8b57 and 143ec89.

📒 Files selected for processing (1)
  • .github/actions/setup-rust-android/action.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Android setup step now requests platform-tools explicitly. Comments explain that the legacy tools package is unavailable and that the runner’s existing cmdline-tools replaces it.

Changes

Android SDK setup

Layer / File(s) Summary
Android SDK package selection
.github/actions/setup-rust-android/action.yml
The setup step requests platform-tools and documents the unavailable legacy tools package and the existing cmdline-tools replacement.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: mabudalam

Merge Risk: ⚪ Minimal · up to 143ec

The change avoids requesting the unavailable legacy tools package while retaining the command-line tools needed for SDK setup. No concrete merge-blocking risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 143ec

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/actions/setup-rust-android/action.yml: The setup-android step now passes packages: platform-tools instead of relying on the action’s default package selection; comments document that the removed legacy tools package caused sdkmanager to fail and identify existing cmdline-tools as its replacement.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the failure, affected workflows, root cause, and proposed fix. However, it leaves the required issue number as a placeholder, does not list dependencies, and leaves all checkl… Replace issue_no with the fixed issue number, state required dependencies or confirm that none are required, and update each checklist item to reflect the completed verification.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: stopping installation of the removed Android SDK "tools" package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the failure, affected workflows, root cause, and proposed fix. However, it leaves the required issue number as a placeholder, does not list dependencies, and leaves all checklist items unchecked.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BrawlerXull
BrawlerXull merged commit d30764f into CCExtractor:main Oct 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant