feat(AddTaskDialog): add end date datetime picker #396
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
ShivaGupta-14
force-pushed
the
feat/325-addtaskdialog-end-datetime-picker
branch
from
918675a to
4c66c2d
Compare
There was a problem hiding this comment.
removed end from cmdArgs (not allowed on pending tasks). Using task done end:<date> to set end date and mark task completed, the way in Taskwarrior.
There was a problem hiding this comment.
update the tests and added test for warning message
ShivaGupta-14
left a comment
ShivaGupta-14
left a comment
There was a problem hiding this comment.
self review done, ready for review, open to feedback and suggestions
ShivaGupta-14
force-pushed
the
feat/325-addtaskdialog-end-datetime-picker
branch
2 times, most recently
from
dbcc89c to
8d1bff7
Compare
|
Maybe use to get the latest task ID, using task export is an overhead for simple tasks like these. Provided the "Add task" will almost always have a task ID |
- Add DateTimePicker for end date in AddTaskDialog - Mark task as completed when end date is set via `task done` command - Show inline warning when end date is selected - Update and add tests
ShivaGupta-14
force-pushed
the
feat/325-addtaskdialog-end-datetime-picker
branch
from
8d1bff7 to
c7cdaf3
Compare
|
done! learn a new thing, i will explore more command :) |
2 participants
Description
Replace DatePicker with DateTimePicker for end field in AddTaskDialog
Add end to dateTimeFields array in tests
Support both date-only and datetime formats for end
Mark task as completed when end date is set via
task donecommand in backendShow inline warning message when end date is selected
Add warning message visibility tests
Fixes: Add additional time picker for time(and date) based fields in AddTaskDialog #325
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Why
task doneis used: Taskwarrior does not allow setting an end date on a pending task. The only way is viatask done end:<date>, which marks the task as completed. Future end dates are allowed (as discussed with maintainer), the inline warning informs users of completion behavior.Screenshots:
Video:
Screen.Recording.2026-01-19.at.12.34.40.AM.mov