[IMPROVEMENT]: Align release.yml trigger with Linux workflows (created → published)#2275
Merged
cfsmp3 merged 1 commit intoMay 31, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
This PR has no runtime reproduction case — it only changes a GitHub Actions trigger.
What this PR does
Single line change in
.github/workflows/release.yml:Nothing else changes — no build steps, no job logic, no workflow names.
Background
release.ymlhas been triggering onrelease: createdsince it was first written in 2021. Every other packaging workflow —build_appimage,build_deb,build_deb_debian13,build_snap,build_linux_systemlibs, andbuild_mac— all userelease: published, makingrelease.ymlthe only remaining workflow that did not. This PR just brings it in line with the rest.For the common case (non-draft releases)
No practical difference. GitHub fires both
createdandpublishedat the same time for a directly-published release, so the workflow runs at the same moment either way.publish_chocolatey.ymlandpublish_winget.ymlare also unaffected — they trigger off the workflow name"Upload releases"viaworkflow_runand only care about whether it succeeded, not which event kicked it off.For draft → publish flows (if used)
This is uncertain since the public release history doesn't tell whether drafts are part of the current process — but worth mentioning. With
created,release.ymlcould run at draft-save time and upload Windows artifacts to a private draft release. If Chocolatey then tries to download the MSI from the public URL before the release is published, that would fail. Withpublished, everything — Windows, Linux, and macOS — would build at the same moment when the release goes public. If drafts aren't part of the process here, this doesn't matter and the change is purely a consistency cleanup.Happy to adjust or close if there's a reason
createdis preferred here.